Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost 1.74.0 #62549

Closed
wants to merge 26 commits into from
Closed

Boost 1.74.0 #62549

wants to merge 26 commits into from

Conversation

HLXEasy
Copy link
Contributor

@HLXEasy HLXEasy commented Oct 8, 2020

The reason for this PR is boostorg/process#92, which should be fixed on Boost 1.74.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

Unfortunately I can't built myself as my XCode version is too old. I have only one Mac at my hands and can't update the machine for other reasons, so it would be cool if somebody else could check this.

  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

See previous comment.

  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

See previous comment.


@HLXEasy
Copy link
Contributor Author

HLXEasy commented Oct 9, 2020

Tests failed with
==> FAILED fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': transfer closed with outstanding read data remaining

Is this my fault?

@jonchang
Copy link
Contributor

jonchang commented Oct 9, 2020

Nah, it's a transient github issue. You'll need to remove this patch though:

https://github.com/Homebrew/homebrew-core/pull/62549/files#diff-5148b5dd1fa3716ad2777ce49eaf03a9L28-L33

@HLXEasy
Copy link
Contributor Author

HLXEasy commented Oct 9, 2020

@jonchang Thx for your response. Which patch do you refer to? If I click on your link, I see just my changes!?

@bayandin
Copy link
Member

bayandin commented Oct 9, 2020

@jonchang Thx for your response. Which patch do you refer to? If I click on your link, I see just my changes!?

This one https://github.com/Homebrew/homebrew-core/blob/2b88bd8e6b64d5fac0966bdde346c48e1e2b6d5c/Formula/boost.rb#L28-L33

It has been merged

@HLXEasy
Copy link
Contributor Author

HLXEasy commented Oct 9, 2020

Ah ok, thx. Will update the PR asap.

@fxcoudert
Copy link
Member

  • Adding other boost-related formulas
  • Squashing the patch removal in the same commit
  • Revision bumping dependents

@fxcoudert
Copy link
Member

brew test --retry --verbose freeling
brew test --retry --verbose i2pd
brew test --retry --verbose pcl
brew test --verbose libbitcoin-protocol
brew test --verbose libbitcoin-client
brew test --verbose libbitcoin-explorer
brew test --verbose libbitcoin-server
brew install --verbose --build-bottle wownero
  • Revision bumps needed for freeling, i2pd, and libbitcoin.
  • pcl is failing to build, but I think it was fixed
  • wownero conflicts with monero

@fxcoudert
Copy link
Member

freeling does not build due to change in checksum: TALP-UPC/FreeLing#111

@fxcoudert
Copy link
Member

And now it's a freeling build failure: TALP-UPC/FreeLing#112

@fxcoudert
Copy link
Member

boost has 40,915 monthly installs, freeling has 8. I'd say we merge this in, and open a separate PR for the freeling revision bump. @Homebrew/core what say you?

jonchang
jonchang previously approved these changes Oct 19, 2020
@SMillerDev
Copy link
Member

Thanks @HLXEasy and @fxcoudert

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @SMillerDev bottle publish failed.

@BrewTestBot BrewTestBot dismissed jonchang’s stale review October 19, 2020 09:16

bottle publish failed

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 19, 2020
@fxcoudert
Copy link
Member

I'll try to merge this one before: #62560

@HLXEasy
Copy link
Contributor Author

HLXEasy commented Oct 19, 2020

Thanks @HLXEasy and @fxcoudert

You're welcome, even if it was way more than I thought initially. So all the fame is dedicated to @fxcoudert

@SMillerDev
Copy link
Member

FX is plenty famous already, he can share.

@fxcoudert
Copy link
Member

fxcoudert commented Oct 19, 2020

  • widelands needs a revision bump
  • given that freeling is not building anymore, probably do not revision bump

Also: I think I'm going to merge #62560 in about 14 hours, so maybe it's worth just waiting a bit to rebase this one when the formulas use python 3.9 (instead of doing it the other way, because this PR is faster to build).

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants