Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arangodb 3.7.3 #63179

Closed
wants to merge 1 commit into from
Closed

arangodb 3.7.3 #63179

wants to merge 1 commit into from

Conversation

KVS85
Copy link
Contributor

@KVS85 KVS85 commented Oct 20, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Oct 20, 2020
@fxcoudert
Copy link
Member

Putting on hold while we merge #62560

@KVS85 KVS85 force-pushed the master branch 4 times, most recently from 66226dc to 8cb53d0 Compare October 21, 2020 16:27
@fxcoudert
Copy link
Member

Please report the issue upstream, and use a patch from their repo if possible.

@KVS85
Copy link
Contributor Author

KVS85 commented Oct 21, 2020

Please report the issue upstream, and use a patch from their repo if possible.

Thanks. It's our own repo but we can't switch to another codebase (3.7.3 was already tagged and built). We didn't notice that on our side until clang at 10.15 was updated. That's already fixed in main branch.

Formula/arangodb.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member

Patch sha checksum doesn't match what you added, please check.

@fxcoudert
Copy link
Member

  • Needs to be rebased on top of master (to remove the revision 1 introduced by the python update).
  • Please add a comment on top of the patch # Fix compilation with Xcode 12, remove in next release

@KVS85
Copy link
Contributor Author

KVS85 commented Oct 23, 2020

  • Needs to be rebased on top of master (to remove the revision 1 introduced by the python update).
  • Please add a comment on top of the patch # Fix compilation with Xcode 12, remove in next release

Done.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants