anime-downloader 5.0.1

[bonkboykz]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[bonkboykz]

@dtrodrigues is there anything wrong with the pr?

[dtrodrigues]

This can be merged after #62560 completes

[fxcoudert]

@dtrodrigues thanks for putting it on hold!

[fxcoudert]

• Please rebase on top of master (because of the python upgrade revision bump)
• Check whether the resources can be updated

[bonkboykz]

* Please rebase on top of master (because of the python upgrade revision bump)

* Check whether the resources can be updated

Done

[bonkboykz]

One of the tests is failing

with

Should I remove revision @fxcoudert ?

[dtrodrigues]

Yes please

[dtrodrigues]

For reference, if you had run brew bump-formula-pr anime-downloader --version=5.0.1(https://docs.brew.sh/Manpage#bump-formula-pr-options-formula), it would have done the version bump, removed the revision, and also checked for resources that needed to be updated and updated urllib3 from 1.25.10 to 1.25.11. It also creates a new branch, pushes it, and creates a PR.

I've pushed the updated urlilb3 version to your branch.

[bonkboykz]

For reference, if you had run brew bump-formula-pr anime-downloader --version=5.0.1, it would have done the version bump, removed the revision, and also seen and updated urllib3 from 1.25.10 to 1.25.11. I've pushed that updated resource to your branch.

I did, but it failed due to some network issues, which I later fixed, and, as far as I know, there's no way to continue bumping the version once it failed

[dtrodrigues]

It should be possible to re-try if it failed along the way due to network issues. I'm wondering if after the failed network issue, the primary url had been updated in which case bump-formula-pr might not work. Resetting to the original one should allow you to re-run the command.

[bonkboykz]

It should be possible to re-try if it failed along the way due to network issues. I'm wondering if after the failed network issue, the primary url had been updated in which case bump-formula-pr might not work. Resetting to the original one should allow you to re-run the command.

I was looking at this comment: Homebrew/brew#3150 (comment)

[dtrodrigues]

The decision of whether or not to restore state was a deliberate one - there are cases where a different error occurred and one might want to continue from that position vs starting over from scratch. You may need to manually revert/manually delete the branch that was auto-created though. As the issue submitter pointed out, deleting the branch should allow you to re-run the command.

Thanks for your patience with this in the middle of our Python 3.9 migration and for your first contribution to Homebrew @bonkboykz!

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[bonkboykz]

The decision of whether or not to restore state was a deliberate one - there are cases where a different error occurred and one might want to continue from that position vs starting over from scratch. You may need to manually revert/manually delete the branch that was auto-created though. As the issue submitter pointed out, deleting the branch should allow you to re-run the command.

Thanks for your patience with this in the middle of our Python 3.9 migration and for your first contribution to Homebrew @bonkboykz!

Got it, I kinda rushed to the first solution I could come up with 😅 I'll try that next time

Thanks for the support, guys!