Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redex: patch for boost 1.74 #63266

Closed
wants to merge 1 commit into from

Conversation

dtrodrigues
Copy link
Member

@dtrodrigues dtrodrigues commented Oct 22, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Adds patch for boost 1.74: facebook/redex#564
This cannot directly be applied since the last tagged release is too old for the patch to directly work

Supports #62560

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Oct 22, 2020
@dtrodrigues
Copy link
Member Author

Irrespective of this update, running brew test redex works but brew test -v redex does not. Also, running the command being tested by hand also doesn't work due to no finding zipalign:

==> /usr/local/Cellar/redex/2017.10.31_5/bin/redex redex-test.apk -o redex-test-out.apk
Couldn't find zipalign. See README.md to resolve this.
Traceback (most recent call last):
  File "/tmp/redex.6rO1iR/redex.py", line 224, in zipalign
    subprocess.check_call(zipalign +
  File "/usr/local/Cellar/python@3.8/3.8.6/Frameworks/Python.framework/Versions/3.8/lib/python3.8/subprocess.py", line 359, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/local/Cellar/python@3.8/3.8.6/Frameworks/Python.framework/Versions/3.8/lib/python3.8/subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/local/Cellar/python@3.8/3.8.6/Frameworks/Python.framework/Versions/3.8/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/local/Cellar/python@3.8/3.8.6/Frameworks/Python.framework/Versions/3.8/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'zipalign'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/redex.6rO1iR/redex.py", line 640, in <module>
    run_redex(args)
  File "/tmp/redex.6rO1iR/redex.py", line 597, in run_redex
    create_output_apk(extracted_apk_dir, args.out, args.sign, args.keystore,
  File "/tmp/redex.6rO1iR/redex.py", line 276, in create_output_apk
    zipalign(unaligned_apk_path, output_apk_path, ignore_zipalign)
  File "/tmp/redex.6rO1iR/redex.py", line 229, in zipalign
    raise Exception('No zipalign executable found')
Exception: No zipalign executable found

The redex script untars itself to get redex.py, which also seems strange.

@dtrodrigues
Copy link
Member Author

@fxcoudert up to you if you want this merged before 3.9 or if you want to ignore this one for now

@dtrodrigues dtrodrigues requested a review from fxcoudert October 22, 2020 02:26
@SMillerDev
Copy link
Member

Can we also deprecate it if they stopped doing releases. I don't want to just collect patches here.

@fxcoudert
Copy link
Member

I'm going to go ahead and merge #62560 before we do anything else

SMillerDev
SMillerDev previously approved these changes Oct 23, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review October 23, 2020 08:21

bottle publish failed

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@dtrodrigues dtrodrigues deleted the redex-boost branch October 25, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants