-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnuradio: migrate to python@3.9 #63345
Conversation
Test is failing, and bottle is not being archived.
|
The bottle is probably not being archived because the test is failing. The test should be removed if it doesn't work. |
I'd argue that's not something we want: we regularly have tests that fail due to network flukes, and we want to be able to merge them without rebuilding everything if we know it's only a network fluke on one of the runners. Also, if I could download the bottle I'd be able to debug what's wrong without having to rebuild on my own system. That's a very useful feature. |
Maybe we could always upload the artifacts by a different name for debugging? I don't think I've seen network flukes in tests for a long time so I'm less worried about those. |
I wonder if we actually want to move this back to python 3.7. Macports (which the gnuradio mac maintainer actually also maintainers) moved to py37 after seeing problems with gr. macports/macports-ports@c7fc6dd. This may address some of the issues we've seen around gnuradio. |
|
First, there is an issue with Once I fix it, locally I get:
This happens because
This may be a local issue on my own cellar. We'll see what CI says… |
We should remove tests that fail due to network flukes. |
Something that is relevant to both here and Homebrew/brew#8980 (so I'll repeat myself in both): the goal is to have a Homebrew/homebrew-core that (eventually) requires green CI for all PRs to be merged. This is the case on this repository (and, frankly, most repositories) and would be better for both a contributor understanding and security perspective. |
Follow-up of #62560
gnuradio
bottle was missing on all 3 CI nodes, for reasons undetermined