ola 0.10.8 #65415

peternewman · 2020-11-22T11:22:04Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting? - I don't have an OS X test machine available anymore
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting? - I don't have an OS X test machine available anymore
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)? - I don't have an OS X test machine available anymore

chenrui333 · 2020-11-22T18:33:29Z

@peternewman, let me know this patch (cdb8f7d) can be removed? it caused the build issue.

peternewman · 2020-11-22T19:02:53Z

@peternewman, let me know this patch (cdb8f7d) can be removed? it caused the build issue.

Yes it can. This isn't 0.11, but I removed the source of that patch in Macports land!

Should I be deleting the patch file from https://github.com/Homebrew/formula-patches/4dcd2679/ola/libmicrohttpd.diff too?

chenrui333 · 2020-11-22T19:11:50Z

checking protoc version... 3.6.1
checking google/protobuf/compiler/command_line_interface.h usability... no
checking google/protobuf/compiler/command_line_interface.h presence... yes
configure: WARNING: google/protobuf/compiler/command_line_interface.h: present but cannot be compiled
configure: WARNING: google/protobuf/compiler/command_line_interface.h:     check for missing prerequisite headers?
configure: WARNING: google/protobuf/compiler/command_line_interface.h: see the Autoconf documentation
configure: WARNING: google/protobuf/compiler/command_line_interface.h:     section "Present But Cannot Be Compiled"
configure: WARNING: google/protobuf/compiler/command_line_interface.h: proceeding with the compiler's result
configure: WARNING:     ## --------------------------------------------- ##
configure: WARNING:     ## Report this to open-lighting@googlegroups.com ##
configure: WARNING:     ## --------------------------------------------- ##
checking for google/protobuf/compiler/command_line_interface.h... no
configure: error: Cannot find the protoc header files

chenrui333 · 2020-11-22T19:12:04Z

@peternewman, let me know this patch (cdb8f7d) can be removed? it caused the build issue.

Yes it can. This isn't 0.11, but I removed the source of that patch in Macports land!

Should I be deleting the patch file from https://github.com/Homebrew/formula-patches/4dcd2679/ola/libmicrohttpd.diff too?

if we dont use it, let's remove it.

peternewman · 2020-11-22T21:52:11Z

checking protoc version... 3.6.1
checking google/protobuf/compiler/command_line_interface.h usability... no
checking google/protobuf/compiler/command_line_interface.h presence... yes
configure: WARNING: google/protobuf/compiler/command_line_interface.h: present but cannot be compiled
configure: WARNING: google/protobuf/compiler/command_line_interface.h:     check for missing prerequisite headers?
configure: WARNING: google/protobuf/compiler/command_line_interface.h: see the Autoconf documentation
configure: WARNING: google/protobuf/compiler/command_line_interface.h:     section "Present But Cannot Be Compiled"
configure: WARNING: google/protobuf/compiler/command_line_interface.h: proceeding with the compiler's result
configure: WARNING:     ## --------------------------------------------- ##
configure: WARNING:     ## Report this to open-lighting@googlegroups.com ##
configure: WARNING:     ## --------------------------------------------- ##
checking for google/protobuf/compiler/command_line_interface.h... no
configure: error: Cannot find the protoc header files

Odd, that used to work fine, although I'm not sure we've tried on clang 12 before.

Blocked behind Homebrew/homebrew-core#65415

peternewman · 2020-11-22T22:15:31Z

Indeed this build was clean 8 days ago on clang 9:
https://travis-ci.org/github/OpenLightingProject/ola/jobs/743671666

peternewman · 2020-11-23T23:41:21Z

I got there in the end @chenrui333 , although the test is failing on 11.0 for some reason, despite compiling fine. I guess olad -l 4 is failing to auto-launch on that OS, but I can't see why from the logging unfortunately.

Formula/ola.rb

chenrui333 · 2020-11-24T04:23:56Z

I have a 11.0 machine, let me build and run the test manually.

chenrui333 · 2020-11-24T04:33:18Z

here is the error for the test failure:

==> Testing ola
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201123-79702-qgm0w2.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ola.rb --debug --verbose
/usr/local/Homebrew/Library/Homebrew/test.rb (Formulary::FromPathLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ola.rb
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
No receipt for 'com.apple.pkg.CLTools_Base' found at '/'.
==> /usr/local/Cellar/ola/0.10.8/bin/ola_plugin_info
common/network/TCPSocket.cpp:158: connect(127.0.0.1:9010): Connection refused
common/network/TCPSocket.cpp:158: connect(127.0.0.1:9010): Connection refused
examples/ola-client.cpp:930: Setup failed

but when I run locally, it seems fine:

$ /usr/local/Cellar/ola/0.10.8/bin/ola_plugin_info
   Id	Plugin Name
--------------------------------------
    1	Dummy
    2	ArtNet
    3	ShowNet
    4	ESP Net
    5	Serial USB
    6	Enttec Open DMX
    7	SandNet
    8	StageProfi
    9	Pathport
   11	E1.31 (sACN)
   12	USB
   14	OSC
   16	KiNET
   17	KarateLight
   18	Milford Instruments
   19	Renard
   21	Open Pixel Control
   22	GPIO
--------------------------------------

chenrui333 · 2020-11-24T04:34:56Z

When I changed the test to use ola_artnet (also individual run works fine for me)

the error becomes as:

==> /usr/local/Cellar/ola/0.10.8/bin/ola_artnet
Usage: /usr/local/Cellar/ola/0.10.8/bin/ola_artnet -d <dev_id> -n <name> -l <long_name> -s <subnet>

Configure ArtNet devices managed by OLA.

  -d, --device <int32_t>
    Id of the device to control.
  -h, --help
    Display the help message
  -l, --log-level <int8_t>
    Set the logging level 0 .. 4.
  -n, --name <string>
    Set the name of the ArtNet device.
  -s, --subnet <int32_t>
    Set the subnet parameter of the ArtNet device.
  -u, --universe <uint32_t>
    List the IPs of ArtNet devices for this universe.
  -v, --version
    Display version information
  --long-name <string>
    Set the long name of the ArtNet device.
  --net <int32_t>
    Set the net parameter of the ArtNet device.
  --scheduler-policy <string>
    The thread scheduling policy, one of {fifo, rr}.
  --scheduler-priority <uint16_t>
    The thread priority, only used if --scheduler-policy is set.
  --syslog
    Send to syslog rather than stderr.
  --use-kqueue
    Use kqueue() rather than select()
/usr/local/Homebrew/Library/Homebrew/shims/scm/git --version
/usr/bin/curl --version
/usr/libexec/java_home --xml --failfast
/usr/libexec/java_home --xml --failfast
sysctl: unknown oid 'hw.optional.arm64'
/usr/local/Homebrew/Library/Homebrew/debrew.rb:18:in `raise'
BuildError: Failed executing: /usr/local/Cellar/ola/0.10.8/bin/ola_artnet

chenrui333 · 2020-11-24T04:37:10Z

this would pass the test in my local

-    system bin/"ola_plugin_info"
+    system bin/"ola_dev_info"

chenrui333 · 2020-11-24T05:40:15Z

@peternewman build is green now, not sure if you still want to put more updates (i do think there is some underlying issue, but it does not impact the actual usage though)

peternewman · 2020-11-24T08:01:40Z

Thanks @chenrui333 . That's strange! Actually because you haven't given it enough options, ola_dev_info is just showing it's help locally, ola_plugin_info is trying to auto-start olad and then failing somehow.

If you change the test to this, does it give anything else more useful:
/usr/local/Cellar/ola/0.10.8/bin/ola_plugin_info -l 4

Also has olad kept running in the background after one of the test runs or manual runs, which could possibly explain the change in behaviour?

They are part of the same codebase ola_plugin_info and ola_dev_info:
https://github.com/OpenLightingProject/ola/blob/e9fcf75fec8a96d2bb91b0f8b41c66765b54aa84/examples/Makefile.mk#L118-L128

SMillerDev · 2020-11-24T08:58:46Z

Seeing those commands at the bottom, does it depend on Java without defining that dependency? Because Big Sur doesn't have a Java version installed.

peternewman · 2020-12-14T21:16:18Z

Seeing those commands at the bottom, does it depend on Java without defining that dependency? Because Big Sur doesn't have a Java version installed.

We've got a Java plugin @SMillerDev (like the Python and C++ ones) but it's not enabled in this build.

I'm not quite sure which commands you're referring to where, there's no Java in that Makefile, just in the java dir. Edit, just seen it; that and curl in particular aren't OLA I don't think.

@chenrui333 did you get a chance to look at my queries?

chenrui333 · 2020-12-19T16:57:45Z

@chenrui333 did you get a chance to look at my queries?

I thought I did dump the local run in here (looks like I did not), let me reinstall and run the cmd really quick. :)

chenrui333 · 2020-12-19T17:53:03Z

looks like we got rid of the protobuf@3.1

chenrui333 · 2020-12-19T17:59:24Z

rebased to the master and building in my local now.

chenrui333 · 2020-12-19T18:39:06Z

@peternewman here is my test result:

test result

==> Testing ola
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201219-68542-1vv0u64.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ola.rb --debug --verbose
/usr/local/Homebrew/Library/Homebrew/test.rb (Formulary::FromPathLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ola.rb
==> /usr/local/Cellar/ola/0.10.8/bin/ola_dev_info
Device 1: Dummy Device
  port 0, OUT Dummy Port, RDM supported
Device 2: ArtNet [10.0.0.239]
  port 0, IN, priority 100, RDM supported
  port 1, IN, priority 100, RDM supported
  port 2, IN, priority 100, RDM supported
  port 3, IN, priority 100, RDM supported
  port 0, OUT, RDM supported
  port 1, OUT, RDM supported
  port 2, OUT, RDM supported
  port 3, OUT, RDM supported
Device 3: ShowNet [10.0.0.239]
  port 0, IN ShowNet 1-512, priority 100
  port 1, IN ShowNet 513-1024, priority 100
  port 2, IN ShowNet 1025-1536, priority 100
  port 3, IN ShowNet 1537-2048, priority 100
  port 4, IN ShowNet 2049-2560, priority 100
  port 5, IN ShowNet 2561-3072, priority 100
  port 6, IN ShowNet 3073-3584, priority 100
  port 7, IN ShowNet 3585-4096, priority 100
  port 0, OUT ShowNet 1-512
  port 1, OUT ShowNet 513-1024
  port 2, OUT ShowNet 1025-1536
  port 3, OUT ShowNet 1537-2048
  port 4, OUT ShowNet 2049-2560
  port 5, OUT ShowNet 2561-3072
  port 6, OUT ShowNet 3073-3584
  port 7, OUT ShowNet 3585-4096
Device 4: ESP Net [10.0.0.239]
  port 0, IN, priority 100
  port 1, IN, priority 100
  port 2, IN, priority 100
  port 3, IN, priority 100
  port 4, IN, priority 100
  port 0, OUT
  port 1, OUT
  port 2, OUT
  port 3, OUT
  port 4, OUT
Device 5: SandNet [10.0.0.239]
  port 0, IN, priority 100
  port 1, IN, priority 100
  port 2, IN, priority 100
  port 3, IN, priority 100
  port 4, IN, priority 100
  port 5, IN, priority 100
  port 6, IN, priority 100
  port 7, IN, priority 100
  port 0, OUT
  port 1, OUT
Device 6: Pathport [10.0.0.239]
  port 0, IN, priority 100
  port 1, IN, priority 100
  port 2, IN, priority 100
  port 3, IN, priority 100
  port 4, IN, priority 100
  port 5, IN, priority 100
  port 6, IN, priority 100
  port 7, IN, priority 100
  port 0, OUT
  port 1, OUT
  port 2, OUT
  port 3, OUT
  port 4, OUT
  port 5, OUT
  port 6, OUT
  port 7, OUT
Device 7: E1.31 (DMX over ACN) [10.0.0.239]
  port 0, IN, priority inherited
  port 1, IN, priority inherited
  port 2, IN, priority inherited
  port 3, IN, priority inherited
  port 4, IN, priority inherited
  port 0, OUT, priority inherited
  port 1, OUT, priority inherited
  port 2, OUT, priority inherited
  port 3, OUT, priority inherited
  port 4, OUT, priority inherited
Device 8: OSC Device
  port 0, IN /dmx/universe/%d, priority 100
  port 1, IN /dmx/universe/%d, priority 100
  port 2, IN /dmx/universe/%d, priority 100
  port 3, IN /dmx/universe/%d, priority 100
  port 4, IN /dmx/universe/%d, priority 100
Device 9: KiNet Device
NOTE:  Most system logs have moved to a new logging system.  See log(1) for more information.


$ /usr/local/Cellar/ola/0.10.8/bin/ola_plugin_info -l 4
   Id	Plugin Name
--------------------------------------
    1	Dummy
    2	ArtNet
    3	ShowNet
    4	ESP Net
    5	Serial USB
    6	Enttec Open DMX
    7	SandNet
    8	StageProfi
    9	Pathport
   11	E1.31 (sACN)
   12	USB
   14	OSC
   16	KiNET
   17	KarateLight
   18	Milford Instruments
   19	Renard
   21	Open Pixel Control
   22	GPIO
--------------------------------------

… 3.6

chenrui333 · 2021-01-27T22:16:08Z

rebased to latest master.

chenrui333 · 2021-01-27T22:16:40Z

Ok, not sure why that failed.

==> Downloading bottles for workflow: tests.yml
Error: No matching workflow run found for these criteria!

I think the artifacts have expired (rebased and re-generate the bottles would do the job)

BrewTestBot · 2021-01-28T02:00:37Z

🤖 A scheduled task has triggered a merge.

BrewTestBot · 2021-01-28T02:27:08Z

❌ @carlocab bottle request for ola failed.

peternewman · 2021-02-13T02:37:41Z

Thanks for the merge, although it looks like building the bottles failed due to protobuf@3.6 for some reason:
https://github.com/Homebrew/homebrew-core/runs/1781419342?check_suite_focus=true#step:6:381

FWIW in theory we should work with later protobuf now I think, if that helps to bypass the issue?

carlocab · 2021-02-13T03:00:06Z

That might work. If you can test it, please do, then open a PR to switch the dependency to the newer protobuf + a revision bump.

peternewman · 2021-02-13T03:42:16Z

That might work. If you can test it, please do, then open a PR to switch the dependency to the newer protobuf + a revision bump.

Unfortunately I can't, as per my comment when opening this PR,

I don't have an OS X test machine available anymore

Which leaves me a bit stuck supporting it on Homebrew. Especially as our Homebrew via Travis as part of our CI has got rather flaky of late so isn't currently running.

I've opened #71036 in the hope the CI will do the job.

BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated python Python use is a significant feature of the PR or issue labels Nov 22, 2020

peternewman marked this pull request as draft November 22, 2020 22:01

peternewman added a commit to peternewman/formula-patches that referenced this pull request Nov 22, 2020

Delete libmicrohttpd.diff

6128fd0

Blocked behind Homebrew/homebrew-core#65415

peternewman mentioned this pull request Nov 22, 2020

ola: Update patches Homebrew/formula-patches#322

Merged

peternewman mentioned this pull request Nov 23, 2020

Fix the Python RPC tests on Big Endian architectures OpenLightingProject/ola#1687

Merged

chenrui333 mentioned this pull request Nov 23, 2020

ola 0.10.8 #65537

Closed

peternewman marked this pull request as ready for review November 23, 2020 23:39

peternewman commented Nov 23, 2020

View reviewed changes

Formula/ola.rb Show resolved Hide resolved

SMillerDev added the do not merge label Nov 25, 2020

peternewman mentioned this pull request Dec 14, 2020

ImportError (google.protobuf) with rdm_test_server.py OpenLightingProject/ola#1599

Closed

peternewman and others added 14 commits January 27, 2021 17:15

ola 0.10.8

d345464

Update ola.rb

6b2210c

remove patch

5a3128e

Switch to the latest protobuf

147912c

ola: Add back in a patch we do still need and switch back to protobuf…

215a62c

… 3.6

ola: Test drive the fixed patch

8f40fee

ola: Add the revision to the test patch

dfb6d50

ola: Update the patch so it applies correctly

70cd800

ola: Update to the working patch

86c1f83

ola: Fix the patch (fourth time lucky?)

faf1681

ola: Update the patch to the correct URL

2443b72

use ola_dev_info for test

6ac80cc

revert test change

b45fd20

Update when we can drop a patch

217f483

chenrui333 force-pushed the patch-1 branch from a1d2de2 to 217f483 Compare January 27, 2021 22:16

BrewTestBot added the no ARM bottle Formula has no ARM bottle label Jan 27, 2021

chenrui333 added the ready to merge PR can be merged once CI is green label Jan 27, 2021

carlocab approved these changes Jan 28, 2021

View reviewed changes

BrewTestBot closed this in e16af3d Jan 28, 2021

peternewman mentioned this pull request Feb 13, 2021

ola: Bump protobuf version to 3.14 #71036

Closed

5 tasks

BrewTestBot added the outdated PR was locked due to age label Mar 16, 2021

Homebrew locked as resolved and limited conversation to collaborators Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ola 0.10.8 #65415

ola 0.10.8 #65415

peternewman commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

peternewman commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

peternewman commented Nov 22, 2020

peternewman commented Nov 22, 2020

peternewman commented Nov 23, 2020

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020 •

edited

Loading

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020

peternewman commented Nov 24, 2020

SMillerDev commented Nov 24, 2020

peternewman commented Dec 14, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020 •

edited

Loading

chenrui333 commented Jan 27, 2021

chenrui333 commented Jan 27, 2021

BrewTestBot commented Jan 28, 2021

BrewTestBot commented Jan 28, 2021

peternewman commented Feb 13, 2021 •

edited

Loading

carlocab commented Feb 13, 2021

peternewman commented Feb 13, 2021

ola 0.10.8 #65415

ola 0.10.8 #65415

Conversation

peternewman commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

peternewman commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

chenrui333 commented Nov 22, 2020

peternewman commented Nov 22, 2020

peternewman commented Nov 22, 2020

peternewman commented Nov 23, 2020

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020 • edited Loading

chenrui333 commented Nov 24, 2020

chenrui333 commented Nov 24, 2020

peternewman commented Nov 24, 2020

SMillerDev commented Nov 24, 2020

peternewman commented Dec 14, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020

chenrui333 commented Dec 19, 2020 • edited Loading

chenrui333 commented Jan 27, 2021

chenrui333 commented Jan 27, 2021

BrewTestBot commented Jan 28, 2021

BrewTestBot commented Jan 28, 2021

peternewman commented Feb 13, 2021 • edited Loading

carlocab commented Feb 13, 2021

peternewman commented Feb 13, 2021

chenrui333 commented Nov 24, 2020 •

edited

Loading

chenrui333 commented Dec 19, 2020 •

edited

Loading

peternewman commented Feb 13, 2021 •

edited

Loading