Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pachi 12.60 #67126

Closed
wants to merge 1 commit into from
Closed

pachi 12.60 #67126

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Dec 18, 2020
@carlocab
Copy link
Member

carlocab commented Dec 18, 2020

license "GPL-2.0-or-later"?

https://github.com/pasky/pachi/search?q=license

url "https://github.com/pasky/pachi/archive/pachi-12.50.tar.gz"
sha256 "62c8d44bd4610fe9534a1f21bb092da209c9fb8dcb8d39558d79adabe31e740a"
url "https://github.com/pasky/pachi/archive/pachi-12.60.tar.gz"
sha256 "3c05cf4fe5206ba4cbe0e0026ec3225232261b44e9e05e45f76193b4b31ff8e9"
license "GPL-2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license "GPL-2.0"
license "GPL-2.0-or-later"

@chenrui333
Copy link
Member Author

that does not look like the license file declaration for the library.

@chenrui333
Copy link
Member Author

cc @Rylan12

@carlocab
Copy link
Member

🤷 on their homepage they link to that repo for the source code and searching their repo for the word license just returns GPL 2 or later.

@Rylan12
Copy link
Member

Rylan12 commented Dec 18, 2020

Hmm, not sure. It kinda looks like the GPL-2.0-or-later that comes up when you search is only for that file (sgflib.py). I'm not sure we can assume that the rest of the repo is GPL-2.0-or-later. Maybe we want to ask upstream?

@carlocab
Copy link
Member

Would be useful to ask upstream I guess. However, my understanding from reading previous discussions about this (in particular FX's comments -- not tagging to avoid useless notifications) is that the license file tells you the general classification (GPL, BSD, etc). But to know which specific kind of license it is, you look at the headers, then choose the most restrictive license classification based on that.

This process gives you GPL-2.0-or-later, I believe.

@carlocab
Copy link
Member

I think I remember reading it here: #58225

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@chenrui333 chenrui333 deleted the bump-pachi-12.60 branch December 18, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated license Formula uses a deprecated SPDX license which should be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants