Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM Big Sur CI #67577

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Add ARM Big Sur CI #67577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ env:
HOMEBREW_DEVELOPER: 1
HOMEBREW_GITHUB_ACTIONS: 1
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_CHANGE_ARCH_TO_ARM: 1
Rylan12 marked this conversation as resolved.
Show resolved Hide resolved
HOMEBREW_REQUIRE_BOTTLED_ARM: 1
jobs:
tap_syntax:
if: github.repository == 'Homebrew/homebrew-core'
Expand Down Expand Up @@ -65,7 +67,7 @@ jobs:
if: github.event_name == 'pull_request' && needs.tap_syntax.outputs.run-tests
Rylan12 marked this conversation as resolved.
Show resolved Hide resolved
strategy:
matrix:
version: ['11.0', '10.15', '10.14']
version: ['11-arm', '11.0', '10.15', '10.14']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain but: could this be updated to 11-arm64 on these workers and, even better still, use 11 instead of 11.0 for Big Sur at some point too (this could be separate tasks and I can open an issue for tracking if easier). This will allow simplifying some code in Homebrew/brew.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need these to be homogeneous at some point, but it's not gonna happen until we are updating the nodes, because it's too much of a pain to do

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, no rush but when the nodes are next updated it'd be much appreciated if you could handle this for the ARM ones (and @Rylan12 @jonchang @Bo98 or whomever handles the Big Sur ones).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it'd be OK to apply both labels for now so code changes aren't needed to have it keep working)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Our runners are already running 11.1 so the names are already out of date 😅. Also agree that this doesn't need to happen immediately. Might be good to get some PRs open to get ready for the next time the nodes are updated.

In terms of things that need to be modified in the brew repo, it looks like it's pretty much just dispatch-build-bottle, right? Looks like the only part that would need to change is the label mapping. And then, once this is complete, this mapping can be removed as well.

I won't be able to do the actual renaming as I'm not an organization owner. Happy to help out with the dispatch-build-bottle and whatever other code changes are needed, though.

fail-fast: false
runs-on: ${{ matrix.version }}
timeout-minutes: 4320
Expand Down