pacparser: fix Big Sur build #67606
Closed
pacparser: fix Big Sur build #67606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile inside pacparser misdetected the OS version "11.1" as "10.1" and therefore decided it couldn't have the va_copy() macro Interestingly, just assigning va_list's happens to work on arm64 so this formula previously bottled OK on big_sur_arm64 but not intel!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile inside pacparser mis-detected the OS version "11.1" as "10.1" and therefore decided it couldn't have the
va_copy()macro.Sent upstream as manugarg/pacparser#104
Interestingly, just assigning va_list's happens to work on arm64 so this formula previously bottled OK on big_sur_arm64 but not intel!