openjdk 15.0.2 #69460

el7cosmos · 2021-01-21T04:16:34Z

Created with brew bump-formula-pr.

resource blocks may require updates.

Formula/openjdk.rb

carlocab · 2021-01-21T06:26:56Z

Patches look like they're no longer necessary:
https://bugs.openjdk.java.net/browse/JDK-8253375
https://bugs.openjdk.java.net/browse/JDK-8253791

They also fail to apply: https://github.com/Homebrew/homebrew-core/runs/1739892097#step:7:63

carlocab · 2021-01-21T07:18:20Z

All three Intel CI nodes:

Error: An exception occurred within a child process:
  RuntimeError: cannot find build number in .hg_archival.txt

These are the contents of .hg_archival.txt:

repo: fd16c54261b32be1aaedd863b7e856801b7f8543
node: 465ac9b408cae3e98c4f4630d22e653e725187ae
branch: default
tag: jdk-15.0.2-ga

Looks like the build number is no longer available here.

homebrew-core/Formula/openjdk.rb

Lines 106 to 111 in f9b4c5b

    
           build = File.read(".hg_archival.txt") 
        
                       .scan(/^tag: jdk-#{version}\+(.+)$/) 
        
                       .map(&:first) 
        
                       .map(&:to_i) 
        
                       .max 
        
           raise "cannot find build number in .hg_archival.txt" if build.nil?

carlocab · 2021-01-21T07:37:44Z

For openjdk 15.0.1, this is the content of .hg_archival.txt:

repo: fd16c54261b32be1aaedd863b7e856801b7f8543
node: d9b7c07593100c3cae95238999f972ceb0ff067c
branch: default
tag: jdk-15.0.1+9
tag: jdk-15.0.1-ga

This gives the build number 9. If we had used the same scheme as ARM to parse the build number from .hgtags, we'd have gotten 8:

❯ tail -10 .hgtags
e3f940bd3c8fcdf4ca704c6eb1ac745d155859d5 jdk-15+36
93813843680bbe1b7efbca56c03fd137f20a2c31 jdk-15.0.1+0
286ddf41c3f697bcf684042544fa4736ba1b85f3 jdk-15.0.1+1
08e8fa30d8456913dd0f698f9c61e4adac22805a jdk-15.0.1+2
99d9a174da61ca1e359638170b47a7ddc9cc77d5 jdk-15.0.1+3
72cddf95705e758aea928e025694e445af844d1f jdk-15.0.1+4
ac7b0cbc8dac94ff225021d2786efbad2326b037 jdk-15.0.1+5
a90f4378bf70eb17e8a8322aa0b94a4c6c923932 jdk-15.0.1+6
23fd169be90a803fef99776afefa3072189980be jdk-15.0.1+7
8dd4d8eaf0de32a79d1f48c3421e5666d75beff9 jdk-15.0.1+8

SMillerDev · 2021-01-21T07:48:12Z

Why do we need to have the build number?

If it's useful I guess we could move to the arm way (since that's where they seem to be going)

carlocab · 2021-01-21T07:53:09Z

Why do we need to have the build number?

No idea.

we could move to the arm way

That would've given a build number of 8 instead of 9 for 15.0.1 though: #69460 (comment) Not sure if that's important at all.

jonchang · 2021-01-21T07:55:04Z

It "should" be +8. Usually they have two tags pointing to a single commit like so:

e3f940bd3c8fcdf4ca704c6eb1ac745d155859d5 jdk-15+36
e3f940bd3c8fcdf4ca704c6eb1ac745d155859d5 jdk-15-ga

for some reason upstream has not done it this time. We could potentially wait for adoptopenjdk to release 15.0.2 to see what build number they pick.

jonchang · 2021-01-21T08:22:46Z

Why do we need to have the build number?

If it's useful I guess we could move to the arm way (since that's where they seem to be going)

Let's just go with this since it's easier. I think build numbers are really only used when comparing among the same java patch version and I think it's a legacy of openjdk 8-era java versioning (like jdk8u282)

carlocab · 2021-01-21T08:36:07Z

Let's just go with this since it's easier.

Done. This is still slightly different from ARM, which uses only the major version, though. However, I assume that's because .hgtags in the ARM tarball only contains lines with the major version (unlike the 15.0.2 tarball).

carlocab · 2021-01-21T09:08:12Z

Same error; still can't find the build number. (I forgot to change the error message to .hgtags.) Not sure why; these are the relevant lines in .hgtags:

❯ tail -8 .hgtags
1613004c47e9dc867a2c2c43d716533b1aaedc5f jdk-15.0.2+0
cc4fdb537bc14734064a9a8eadb091fd1c12b36e jdk-15.0.2+1
d24e907486b3f90691980b0dde01efca5840abc6 jdk-15.0.2+2
dbb11e11955ad1240ba775ab0007a14547e14ce6 jdk-15.0.2+3
4c4a2eb7b19ecb31620e6bb120e40f8a5fd1737a jdk-15.0.2+4
e431a9461b1356c4b763443e5333b3f4a8695eaf jdk-15.0.2+5
d5977ee56509ceaa3d3c8e1aebbca76651358da4 jdk-15.0.2+6
38912b2a5bcb396c75f8707e300773c874327451 jdk-15.0.2+7

Ah, I see. I forgot to remove the ^ from the regex.

carlocab · 2021-01-21T09:29:23Z

Re the build number: #68946 (comment)

It seems we should add one to it on Intel? (I'm not even sure how important this is.)

carlocab · 2021-01-21T09:31:59Z

ARM CI broken by Homebrew/brew#10375.

Error: Invalid usage: not (yet) working on Apple Silicon!

carlocab · 2021-01-23T22:20:55Z

Big Sur

Error: 12 failed steps!
brew test --retry --verbose byteman
brew install --build-from-source emscripten
brew test --retry --verbose fits
brew test --retry --verbose jasmin
brew test --retry --verbose jetty
brew install --build-from-source languagetool
brew install --build-from-source man-db
brew install --build-from-source mesos
brew test --retry --verbose nexus
rm -rf /Users/brew/Library/Caches/Homebrew
brew install --build-from-source planck
brew install --build-from-source simutrans

Catalina

Error: 8 failed steps!
brew test --retry --verbose byteman
brew test --retry --verbose fits
brew test --retry --verbose jasmin
brew test --retry --verbose jetty
brew install --build-from-source man-db
brew install --build-from-source mesos
brew install --build-from-source planck
brew install --build-from-source simutrans

Mojave

Error: 5 failed steps!
brew test --retry --verbose byteman
brew test --retry --verbose fits
brew test --retry --verbose jasmin
brew test --retry --verbose jetty
brew install --build-from-source planck

jonchang · 2021-01-26T04:47:38Z

Looks like adoptopenjdk is using 15.0.2+7 🤷

BrewTestBot · 2021-02-28T00:50:20Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Needed for #69460 Closes #72153. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: Jonathan Chang <me@jonathanchang.org>

jonchang · 2021-03-02T04:15:59Z

mesos and man-db are now fixed, so hopefully this CI run works.

jonchang · 2021-03-03T02:23:56Z

Mojave is 🍏 🙏

carlocab · 2021-03-03T17:06:54Z

Big Sur:

Error: 4 failed steps!
rm -rf /Users/brew/Library/Caches/Homebrew
brew install --build-from-source emscripten
rm -rf /Users/brew/Library/Caches/Homebrew
brew install --build-from-source varnish

Catalina:

Error: 2 failed steps!
brew install --build-from-source root
brew install --build-from-source varnish

emscripten:

cp: /private/tmp/emscripten--llvm-20210302-46554-1i290gk/.git/packed-refs: No space left on device

varnish: #72404

root:

==> brew install --build-from-source root
==> FAILED
==> Downloading https://root.cern.ch/download/root_v6.22.06.source.tar.gz
curl: (56) LibreSSL SSL_read: error:06FFF064:digital envelope routines:CRYPTO_internal:bad decrypt, errno 0
Error: Failed to download resource "root"
Download failed: https://root.cern.ch/download/root_v6.22.06.source.tar.gz

A little surprised the ARM runner is still going.

carlocab · 2021-03-04T11:04:40Z

ARM runner is still going. It seems to be weird to have to wait for it, given that this PR should have no impact on the ARM bottle other than renaming it...

jonchang · 2021-03-05T00:53:58Z

I'm just going to publish these bottles. OpenJDK 16 is coming out in a few weeks so we need to direct our energy there 🤷

BrewTestBot · 2021-03-05T00:54:41Z

@jonchang has triggered a merge.

jonchang · 2021-03-05T00:58:39Z

I logged into the ARM runner and determined that an automatic update (of the runner) seemed to have killed the runner instance, which is why the tests were stalled.

carlocab reviewed Jan 21, 2021

View reviewed changes

Formula/openjdk.rb Outdated Show resolved Hide resolved

carlocab reviewed Jan 21, 2021

View reviewed changes

Formula/openjdk.rb Outdated Show resolved Hide resolved

carlocab force-pushed the bump-openjdk-15.0.2 branch 2 times, most recently from 2c8baf8 to 9bdad7e Compare January 21, 2021 09:18

jonchang force-pushed the bump-openjdk-15.0.2 branch from 9bdad7e to 3f9024b Compare January 26, 2021 04:48

This was referenced Jan 31, 2021

planck: set JAVA_HOME to fix build from source #70078

Closed

simutrans: don't use resource #70080

Closed

byteman: fix test #70088

Merged

arrennbaral mentioned this pull request Feb 3, 2021

Cassandra 3.11.9_1 crashes in openjdk@8 JVM #66462

Closed

4 tasks

jonchang force-pushed the bump-openjdk-15.0.2 branch from 3f9024b to 1ba9cee Compare February 6, 2021 13:12

BrewTestBot added the stale No recent activity label Feb 28, 2021

This was referenced Feb 28, 2021

man-db: disable gettext opportunistic linkage #72153

Closed

mesos 1.11.0 #72154

Closed

BrewTestBot pushed a commit that referenced this pull request Mar 1, 2021

man-db: disable gettext opportunistic linkage

d85da46

Needed for #69460 Closes #72153. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: Jonathan Chang <me@jonathanchang.org>

el7cosmos and others added 2 commits March 2, 2021 15:14

openjdk 15.0.2

5122f44

Update sha256, ARM version

7167a22

carlocab added 2 commits March 2, 2021 15:14

remove Intel patches

827977e

parse build number from .hgtags

c1dfb99

jonchang force-pushed the bump-openjdk-15.0.2 branch from 1ba9cee to c1dfb99 Compare March 2, 2021 04:15

BrewTestBot removed the stale No recent activity label Mar 2, 2021

BrewTestBot closed this in ecd2b29 Mar 5, 2021

el7cosmos deleted the bump-openjdk-15.0.2 branch March 5, 2021 02:55

dtrodrigues mentioned this pull request Mar 18, 2021

OpenJDK post-install fails without Xcode on M1 #69100

Closed

4 tasks

BrewTestBot added the outdated PR was locked due to age label Apr 6, 2021

Homebrew locked as resolved and limited conversation to collaborators Apr 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openjdk 15.0.2 #69460

openjdk 15.0.2 #69460

el7cosmos commented Jan 21, 2021

carlocab commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021

SMillerDev commented Jan 21, 2021

carlocab commented Jan 21, 2021

jonchang commented Jan 21, 2021

jonchang commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021

carlocab commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021

carlocab commented Jan 21, 2021

carlocab commented Jan 23, 2021

jonchang commented Jan 26, 2021

BrewTestBot commented Feb 28, 2021

jonchang commented Mar 2, 2021

jonchang commented Mar 3, 2021

carlocab commented Mar 3, 2021 •

edited

Loading

carlocab commented Mar 4, 2021

jonchang commented Mar 5, 2021

BrewTestBot commented Mar 5, 2021

jonchang commented Mar 5, 2021

openjdk 15.0.2 #69460

openjdk 15.0.2 #69460

Conversation

el7cosmos commented Jan 21, 2021

carlocab commented Jan 21, 2021 • edited Loading

carlocab commented Jan 21, 2021 • edited Loading

carlocab commented Jan 21, 2021

SMillerDev commented Jan 21, 2021

carlocab commented Jan 21, 2021

jonchang commented Jan 21, 2021

jonchang commented Jan 21, 2021 • edited Loading

carlocab commented Jan 21, 2021

carlocab commented Jan 21, 2021 • edited Loading

carlocab commented Jan 21, 2021

carlocab commented Jan 21, 2021

carlocab commented Jan 23, 2021

jonchang commented Jan 26, 2021

BrewTestBot commented Feb 28, 2021

jonchang commented Mar 2, 2021

jonchang commented Mar 3, 2021

carlocab commented Mar 3, 2021 • edited Loading

carlocab commented Mar 4, 2021

jonchang commented Mar 5, 2021

BrewTestBot commented Mar 5, 2021

jonchang commented Mar 5, 2021

carlocab commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021 •

edited

Loading

jonchang commented Jan 21, 2021 •

edited

Loading

carlocab commented Jan 21, 2021 •

edited

Loading

carlocab commented Mar 3, 2021 •

edited

Loading