git-interactive-rebase-tool 2.0.0 #70612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
no ARM bottle
MitMaro
force-pushed
the
bump-git-interactive-rebase-tool-2.0.0
branch
from
7700b3e to
5976da2
Compare
|
Looks like this works on Linux (linuxbrew), but not on macOS. I will need to investigate later. |
This update was non-simple as the existing tests were broken by changes in the project. The tests failed because the existing tests depend on reading input from stdin, but this project no longer supports reading from stdin in all cases. To fix this, providing a noop rebase file will allow the application to run and successfully exit, without the need to virtually interact with the program. Also, the project no longer depends on ncurses, so that dependency has been removed.
MitMaro
force-pushed
the
bump-git-interactive-rebase-tool-2.0.0
branch
from
5976da2 to
6e92f3f
Compare
MitMaro
force-pushed
the
bump-git-interactive-rebase-tool-2.0.0
branch
2 times, most recently
from
6ae953e to
6e92f3f
Compare
SMillerDev
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Thanks @MitMaro ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This update was non-simple as the existing tests were broken by changes in the project. The tests failed because the existing tests depend on reading input from stdin, but this project no longer supports reading from stdin in all cases. To fix this, providing a noop rebase file will allow the application to run and successfully exit, without the need to virtually interact with the program. I think this is due to an upstream issue in Crossterm, but I can't be sure.
Also, the project no longer depends on ncurses, so that dependency has been removed.
There is also an existing PR but the tests are failing and this should fix them.