gnutls: Also bootstrap CA bundle using System keychain #71282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure look to me like a false positive. |
|
Can you make sure this has all the changes you made after reviews to the OpenSSL PR? |
Add /Library/Keychains/System.keychain to the keychains used for for seeding the cert.pem bundle. gnutls duplicate of openssl #71191
|
Updated per #71191 |
|
@jonchang I think the do-not-merge label can now safely be removed. |
SeekingMeaning
approved these changes
Mar 21, 2021
|
🤖 A scheduled task has triggered a merge. |
5 tasks
BrewTestBot
pushed a commit
that referenced
this pull request
Mar 23, 2021
Add /Library/Keychains/System.keychain to the keychains used for for seeding the cert.pem bundle. Same has been done for: * openssl@1.1: #71191 * gnutls: #71282 Closes #73620. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Add /Library/Keychains/System.keychain to the keychains used for for seeding the cert.pem bundle.
System.keychain is the authorative keychain for organization installed CAs.
SystemRootCertificates.keychain is only for default Apple installed CAs.
Fixes: #5291
Same change for OpenSSL: #71191