Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-agent 0.1.3 (new formula) #71440

Closed
wants to merge 1 commit into from
Closed

yubikey-agent 0.1.3 (new formula) #71440

wants to merge 1 commit into from

Conversation

FiloSottile
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This formula was previously in a custom tap. Open question: how do I ensure the migration for users who had installed from the custom tap is smooth? Should I add some rename file to my tap?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Feb 18, 2021
Formula/yubikey-agent.rb Outdated Show resolved Hide resolved
Formula/yubikey-agent.rb Outdated Show resolved Hide resolved
Formula/yubikey-agent.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member

Re taps:

You can add yubikey-agent to tap_migrations.json in your tap. You can look here or here for examples.

@FiloSottile
Copy link
Contributor Author

Thank you for the feedback, I think I addressed everything and I will add a tap_migrations.json once this is merged!

FiloSottile added a commit to FiloSottile/yubikey-agent that referenced this pull request Feb 18, 2021
Working to get it upstreamed in Homebrew/homebrew-core#71440, and I will
leave behind a tap_migrations.json in the master branch.
Formula/yubikey-agent.rb Outdated Show resolved Hide resolved
Formula/yubikey-agent.rb Outdated Show resolved Hide resolved
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FiloSottile ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 23, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 23, 2021
@FiloSottile FiloSottile deleted the filippo/yubikey-agent branch July 28, 2021 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants