Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: use last major version to bootstrap current version #71532

Closed
wants to merge 1 commit into from

Conversation

kevinburke1
Copy link

@kevinburke1 kevinburke1 commented Feb 19, 2021

There is nothing special about Go 1.7, and a more recent version of Go
is both supported and should compile more quickly - on my machine this
saves about 5 seconds. See discussion in #71370 for more on why make
this change.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Closes #71370

There is nothing special about Go 1.7, and a more recent version of Go
is both supported and should compile more quickly - on my machine this
saves about 5 seconds. See discussion in Homebrew#71370 for more on why make
this change.
@kevinburke1
Copy link
Author

This doesn't affect the ongoing effort to update the Go formula to 1.16.

@Bo98
Copy link
Member

Bo98 commented Feb 20, 2021

Go pull requests take a very long time (24 hours) to go through CI.

Since we've agreed that we should use the same version on ARM and Intel, and we are going to update to 1.16 stable bootstrap on ARM anyway (1.15 doesn't work on ARM) as a part of the Go 1.16 update, I will handle this in that Go 1.16 pull request when I rebase it - it's much more efficient on our limited resources to do both at the same time. I hope to get Go 1.16 merged this weekend.

Thanks for the contribution though!

@Bo98 Bo98 closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.rb: use latest stable release for Go source installs
2 participants