lightgbm 3.2.0

[chenrui333]

action-homebrew-bump-formula

---

Created with brew bump-formula-pr.

[StrikerRUS]

@chenrui333 Thank you very much for updating the formula!

Reason of failing CI is in GitHub doesn't include submodules into auto-created artifacts. And it seems that they don't have plans to do this. I've just uploaded complete sources that should be built OK.

Refer to the discussion microsoft/LightGBM#3872 (comment) for more details.

[SMillerDev]

Maybe we're better of with a checkout with submodules then?

[StrikerRUS]

@SMillerDev

Maybe we're better of with a checkout with submodules then?

If this is supported by Homebrew and not hard to implement, I think it will be more reliable than handcrafted archives.
But we're going to automate the process of publishing complete source code at CI level, so there will be no time delta between new release and attaching correct *.tar.gz artifact.

[SMillerDev]

You just switch from an archive to specifying a tag and a revision.

[StrikerRUS]

@SMillerDev

You just switch from an archive to specifying a tag and a revision.

Like this one?

[carlocab]

Some of these external libs are provided by Homebrew (e.g. eigen, fmt). Can we use Homebrew dependencies for those?

For the remaining two: compute should probably be provided by boost, and fast_double_parser could probably be a new formula.

[StrikerRUS]

@carlocab

Some of these external libs are provided by Homebrew (e.g. eigen, fmt). Can we use Homebrew dependencies for those?

To be honest, I don't think it is possible and good idea.

We run tests in LightGBM only against fixed commits of those external libs. New versions might be incompatible and break the code. If Homebrew is able to specify exact commit hash for a dependency, it is not a problem, though.

More serious problem is that LightGBM expects all these dependencies to be located in a specific place (we don't respect system-wide installations and need sources of those libs, not compiled files), e.g.
https://github.com/microsoft/LightGBM/blob/4e47c9350828aca5c86ee4221cd72a9aac5e3796/include/LightGBM/utils/common.h#L33-L37

[StrikerRUS]

compute should probably be provided by boost

boost is not needed for ordinary (currently the only available option in Homebrew) installation of LightGBM.

[SMillerDev]

We run tests in LightGBM only against fixed commits of those external libs. New versions might be incompatible and broke the code. If Homebrew is able to specify exact commit hash for a dependency, it is not a problem, though.

That is conflicting with our requirements for formulae: https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[BrewTestBot]

⚠️ Bottle publish failed.

bottle publish failed

[BrewTestBot]

🤖 A scheduled task has triggered a merge.