Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bottle :unneeded on Bintray #75946

Closed
wants to merge 7 commits into from
Closed

Remove bottle :unneeded on Bintray #75946

wants to merge 7 commits into from

Conversation

MikeMcQuaid
Copy link
Member

Part of #74335 and #75943

Needed for Homebrew/brew#11239

@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Apr 26, 2021
@MikeMcQuaid
Copy link
Member Author

Maintainers: feel free to commit directly to this on any failures. I'm almost 100% sure denominator will fail.

@samford samford mentioned this pull request Apr 26, 2021
5 tasks
@samford
Copy link
Member

samford commented Apr 26, 2021

Neither denominator nor kaitai-struct-compiler have migrated from Bintray yet, so we can't update the URLs to fix those. Do we want to keep those commits (with CI failing) or drop them to allow this PR to pass CI?

groovysdk was also failing but they've migrated to Artifactory and I updated the URL in #75955. Rebasing this PR will address that failure but I wanted to hear what we want to do with the other failures before unnecessarily setting off another CI run.

@Bo98
Copy link
Member

Bo98 commented Apr 26, 2021

Bintray had a brown-out so it will pass again if we re-run in a couple hours.

Obviously we still ideally want to update the URLs but there's not much we can do if there's simply no other source yet.

@samford
Copy link
Member

samford commented Apr 26, 2021

The brownout seems to be over now, so I've rebased this to pick up the groovysdk update. Let's see how it does this time around.

@MikeMcQuaid
Copy link
Member Author

I'm going to rebase/hold off on this until Homebrew/brew#11253 is merged.

@MikeMcQuaid MikeMcQuaid added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Apr 27, 2021
@samford
Copy link
Member

samford commented Apr 27, 2021

This is currently failing because the denominator install step doesn't seem to make denominator executable or available in bin. I don't have much experience with Java formulae but I compared this to similar formulae and this seemed to be the minimum to make it work:

(libexec/"bin").install "denominator-cli-#{version}-fat.jar" => "denominator"
(libexec/"bin/denominator").chmod 0755
(bin/"denominator").write_env_script libexec/"bin/denominator", JAVA_HOME: Formula["openjdk"].opt_prefix

@Bo98
Copy link
Member

Bo98 commented Apr 27, 2021

bin.write_jar_script is probably better:

(libexec/"bin").install "denominator-cli-#{version}-fat.jar"
bin.write_jar_script libexec/"bin/denominator-cli-#{version}-fat.jar", "denominator"

@BrewTestBot
Copy link
Member

:shipit: @MikeMcQuaid has triggered a merge.

@MikeMcQuaid MikeMcQuaid deleted the bintray_bottle_unneeded branch April 28, 2021 08:03
@chenrui333 chenrui333 added the bottle-up-everything Make every formula bottled label May 3, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants