Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folly fizz wangle 2021.06.14.00 #79304

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

update to latest

@dtrodrigues
Copy link
Member Author

upstream build issue with watchman, will re-try without watchman. https://github.com/Homebrew/homebrew-core/pull/79304/checks?check_run_id=2819720958

In file included from /tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/tests/PendingCollectionTest.cpp:4:
In file included from /tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/PendingCollection.h:5:
/tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/watchman_string.h:114:16: error: no member named 'data' in 'watchman_pending_fs'
      : s_(str.data()), e_(str.data() + str.size()) {}
           ~~~ ^
/opt/homebrew/include/gtest/gtest-printers.h:215:12: note: in instantiation of function template specialization 'w_string_piece::w_string_piece<watchman_pending_fs, 0>' requested here
    *os << value;
           ^
/opt/homebrew/include/gtest/gtest-printers.h:312:12: note: in instantiation of function template specialization 'testing::internal::internal_stream_operator_without_lexical_name_lookup::StreamPrinter::PrintValue<watchman_pending_fs, void, std::__1::basic_ostream<char> &>' requested here
  Printer::PrintValue(value, os);
           ^
/opt/homebrew/include/gtest/gtest-printers.h:441:13: note: in instantiation of function template specialization 'testing::internal::PrintWithFallback<watchman_pending_fs>' requested here
  internal::PrintWithFallback(value, os);
            ^
/opt/homebrew/include/gtest/gtest-printers.h:691:5: note: in instantiation of function template specialization 'testing::internal::PrintTo<watchman_pending_fs>' requested here
    PrintTo(value, os);
    ^
/opt/homebrew/include/gtest/gtest-printers.h:617:26: note: in instantiation of member function 'testing::internal::UniversalPrinter<watchman_pending_fs>::Print' requested here
    UniversalPrinter<T>::Print(*ptr, os);
                         ^
/opt/homebrew/include/gtest/gtest-printers.h:629:4: note: (skipping 9 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
  (PrintSmartPointer<T>)(ptr, os, 0);
   ^
/tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/tests/PendingCollectionTest.cpp:210:3: note: in instantiation of function template specialization 'testing::internal::CmpHelperNE<nullptr_t, std::__1::shared_ptr<watchman_pending_fs>>' requested here
  ASSERT_NE(nullptr, item);
  ^
/opt/homebrew/include/gtest/gtest.h:2077:32: note: expanded from macro 'ASSERT_NE'
# define ASSERT_NE(val1, val2) GTEST_ASSERT_NE(val1, val2)
                               ^
/opt/homebrew/include/gtest/gtest.h:2059:44: note: expanded from macro 'GTEST_ASSERT_NE'
  ASSERT_PRED_FORMAT2(::testing::internal::CmpHelperNE, val1, val2)
                                           ^
/opt/homebrew/include/gtest/internal/gtest-internal.h:472:44: note: in instantiation of member function 'PendingCollectionFixture_add_one_item_Test<(anonymous namespace)::NaivePendingCollection>::TestBody' requested here
  Test* CreateTest() override { return new TestClass; }
                                           ^
/opt/homebrew/include/gtest/internal/gtest-internal.h:740:13: note: in instantiation of member function 'testing::internal::TestFactoryImpl<PendingCollectionFixture_add_one_item_Test<(anonymous namespace)::NaivePendingCollection>>::CreateTest' requested here
        new TestFactoryImpl<TestClass>);
            ^
/opt/homebrew/include/gtest/internal/gtest-internal.h:744:57: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<PendingCollectionFixture, testing::internal::TemplateSel<PendingCollectionFixture_add_one_item_Test>, testing::internal::Types<(anonymous namespace)::NaivePendingCollection>>::Register' requested here
                                 typename Types::Tail>::Register(prefix,
                                                        ^
/tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/tests/PendingCollectionTest.cpp:203:1: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<PendingCollectionFixture, testing::internal::TemplateSel<PendingCollectionFixture_add_one_item_Test>, testing::internal::Types<PendingChanges, (anonymous namespace)::NaivePendingCollection>>::Register' requested here
TYPED_TEST(PendingCollectionFixture, add_one_item) {
^
/opt/homebrew/include/gtest/gtest-typed-test.h:212:27: note: expanded from macro 'TYPED_TEST'
              CaseName)>::Register("",                                        \
                          ^
In file included from /tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/tests/PendingCollectionTest.cpp:4:
In file included from /tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/PendingCollection.h:5:
/tmp/watchman-20210614-30931-2yy9ld/watchman-2021.06.14.00/watchman_string.h:114:32: error: no member named 'data' in 'watchman_pending_fs'
      : s_(str.data()), e_(str.data() + str.size()) {}
                           ~~~ ^
2 errors generated.
make[2]: *** [CMakeFiles/PendingCollectionTest.t.dir/tests/PendingCollectionTest.cpp.o] Error 1
make[1]: *** [CMakeFiles/PendingCollectionTest.t.dir/all] Error 2
make: *** [all] Error 2

@dtrodrigues dtrodrigues force-pushed the folly-fizz-wangle-watchman-2021.06.14.00 branch from 61f4c48 to 59457b9 Compare June 14, 2021 13:13
@dtrodrigues dtrodrigues changed the title Folly fizz wangle watchman 2021.06.14.00 Folly fizz wangle 2021.06.14.00 Jun 14, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab mentioned this pull request Jun 20, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
@dtrodrigues dtrodrigues deleted the folly-fizz-wangle-watchman-2021.06.14.00 branch May 7, 2022 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants