-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ciphey 5.14.0 (new formula) #80479
ciphey 5.14.0 (new formula) #80479
Conversation
5a153cf
to
c2d24b9
Compare
I'm working on a fix for the Linux CI. |
I added Ciphey to MacPorts and wrote a few things about packaging Ciphey (Ciphey/CipheyCore#17). I'm just going to have a quick look through the formula before it's merged if that's ok. Also, congrats @alebcay on getting this working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alebcay for doing this. I left a few notes that may or may not be applicable for Homebrew. Also just so you're aware, cipheycore requires C++20 if that makes any difference.
@alebcay if you rebase this the Linux CI should be green, we do not build Linux bottles for new formulae (yet) here. I fixed the CI for that case. |
Don't worry. No need to rebase, just rerun jobs. |
c2d24b9
to
9c1a49c
Compare
Thanks for the pointers, @harens. I've left the dev deps in for now. Since Homebrew doesn't have a notion of formula ownership, keeping all of the deps in makes future maintenance easier for people unfamiliar with the nature of which dependencies are actually needed, especially if Ciphey's dependencies change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for submitting this @alebcay! 🎉
9c1a49c
to
178ddfd
Compare
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?