Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ciphey 5.14.0 (new formula) #80479

Closed
wants to merge 1 commit into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Jul 2, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Jul 2, 2021
nandahkrishna
nandahkrishna previously approved these changes Jul 3, 2021
Formula/ciphey.rb Outdated Show resolved Hide resolved
@alebcay alebcay force-pushed the ciphey-new-formula branch from 5a153cf to c2d24b9 Compare July 3, 2021 11:26
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 3, 2021
@alebcay alebcay requested a review from nandahkrishna July 3, 2021 13:58
nandahkrishna
nandahkrishna previously approved these changes Jul 3, 2021
@iMichka
Copy link
Member

iMichka commented Jul 3, 2021

I'm working on a fix for the Linux CI.

@harens
Copy link
Contributor

harens commented Jul 3, 2021

I added Ciphey to MacPorts and wrote a few things about packaging Ciphey (Ciphey/CipheyCore#17). I'm just going to have a quick look through the formula before it's merged if that's ok.

Also, congrats @alebcay on getting this working!

Copy link
Contributor

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alebcay for doing this. I left a few notes that may or may not be applicable for Homebrew. Also just so you're aware, cipheycore requires C++20 if that makes any difference.

Formula/ciphey.rb Outdated Show resolved Hide resolved
Formula/ciphey.rb Outdated Show resolved Hide resolved
Formula/ciphey.rb Show resolved Hide resolved
@iMichka
Copy link
Member

iMichka commented Jul 3, 2021

@alebcay if you rebase this the Linux CI should be green, we do not build Linux bottles for new formulae (yet) here. I fixed the CI for that case.

@dawidd6
Copy link
Member

dawidd6 commented Jul 3, 2021

Don't worry. No need to rebase, just rerun jobs.

@alebcay
Copy link
Member Author

alebcay commented Jul 3, 2021

Thanks for the pointers, @harens. I've left the dev deps in for now. Since Homebrew doesn't have a notion of formula ownership, keeping all of the deps in makes future maintenance easier for people unfamiliar with the nature of which dependencies are actually needed, especially if Ciphey's dependencies change.

@alebcay alebcay requested a review from nandahkrishna July 4, 2021 00:20
Formula/ciphey.rb Outdated Show resolved Hide resolved
harens
harens previously approved these changes Jul 4, 2021
Copy link
Contributor

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for submitting this @alebcay! 🎉

@BrewTestBot
Copy link
Member

:shipit: @nandahkrishna has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants