Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.54.0 #82155

Closed
Closed

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Jul 30, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Jul 30, 2021
@branchvincent branchvincent force-pushed the bump-rust-1.54.0 branch 2 times, most recently from f65c73f to c92388c Compare July 30, 2021 00:45
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 1, 2021
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away and removed stale No recent activity labels Aug 1, 2021
@branchvincent
Copy link
Member Author

branchvincent commented Aug 4, 2021

10.14/10.15:

Error: 16 failed steps!
brew install --build-from-source audacious # build configuration error
brew install --build-from-source bat # compilation error
brew install --build-from-source cargo-instruments # compilation error
brew install --build-from-source flux  # compilation error
brew install --build-from-source gegl # missing build dep
brew install --build-from-source gifski # missing cargo dep
brew install --build-from-source git-interactive-rebase-tool # compilation error
brew install --build-from-source grin-wallet # compilation error
brew test --retry --verbose ktmpl
brew install --build-from-source leaf-proxy # compilation error
brew install --build-from-source pdfpc # compilation error
brew fetch --build-from-source --retry qmmp # 404, ok now
brew install --build-from-source rover # compilation error
brew install --build-from-source vice # missing build dep
brew install --build-from-source visp # compilation error
brew install --build-from-source watchman # compilation error

11:

# Above plus
brew test --retry --verbose asuka
brew test --retry --verbose asuka
brew install --build-from-source deno #  No space left on device
brew install --build-from-source pc6001vx

@branchvincent branchvincent mentioned this pull request Aug 6, 2021
6 tasks
@cho-m
Copy link
Member

cho-m commented Aug 10, 2021

Some potentially fixed (or soon to be fixed) items:

I think the bat failure (and any similar failure) is important to look into as it looks like a change in Rust from 1.53 to 1.54. Probably requires some additional analysis to determine if upstream(s) need a tracking issue.

Some other failures have been occurring for almost every recent Rust update, so probably should compare with last few PRs. Can probably ignore the common failures.

@cho-m
Copy link
Member

cho-m commented Aug 14, 2021

Any formula that fails with error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements is due to current git2 version:

@carlocab
Copy link
Member

asuka was bumped in #83156. Might be fixed already.

@branchvincent
Copy link
Member Author

Opened a pr for cargo-instruments: cmyr/cargo-instruments#43

@branchvincent
Copy link
Member Author

branchvincent commented Aug 16, 2021

I think this is pretty close!

Pre-existing failures:

New failures:

@branchvincent branchvincent mentioned this pull request Aug 16, 2021
6 tasks
@carlocab
Copy link
Member

visp's dependency on Rust is pretty remote. It would be very surprising if the failure were related to this version bump.

This was referenced Aug 16, 2021
@branchvincent
Copy link
Member Author

branchvincent commented Aug 17, 2021

Not seeing any build failure with visp after downloading the bottle and trying against latest master (although maybe this doesn't prove much):

brew install ./rust--1.54.0.big_sur.bottle.tar.gz
brew install -s visp

also, double checked the arm failures and all were pre-existing.

i think this is ready?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @branchvincent!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@branchvincent branchvincent deleted the bump-rust-1.54.0 branch August 17, 2021 03:36
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants