Skip to content

Conversation

@Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 1, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Ninja pulls in Python and its dependency tree. We want the the curl dependency tree to be quite light.

Also add plain HTTP mirrors.

@Bo98 Bo98 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Oct 1, 2021
@carlocab
Copy link
Member

carlocab commented Oct 1, 2021

An alternative here (that we could probably do as well) is to drop the Python3 dependency from Ninja. I think it's only needed for generating graphs and such. Building stuff works just fine without Python.

@Bo98
Copy link
Member Author

Bo98 commented Oct 1, 2021

An alternative here (that we could probably do as well) is to drop the Python3 dependency from Ninja.

I still feel ninja is one more unnecessary dependency here (with no real benefit), but it's probably good to do that anyway. Sounds like dropping the dep would work while still retaining functionality should the user install Python themselves.

@BrewTestBot
Copy link
Contributor

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants