Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 17.0.1 #87602

Closed
wants to merge 3 commits into from
Closed

node 17.0.1 #87602

wants to merge 3 commits into from

Conversation

derekschinke
Copy link
Contributor

@derekschinke derekschinke commented Oct 19, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 19, 2021
@branchvincent
Copy link
Member

we can update npm nodejs/node#40463:

  resource "npm" do
    url "https://registry.npmjs.org/npm/-/npm-8.1.0.tgz"
    sha256 "301ddf6bdbd6f6abb36de144902914c6bb4d6f7463758774fdd0a9ee7c597d34"
  end

Formula/node.rb Outdated
@@ -25,7 +25,7 @@ class Node < Formula
depends_on "icu4c"
depends_on "libnghttp2"
depends_on "libuv"
depends_on "openssl@1.1"
depends_on "openssl@3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: 91 problems in 91 formulae detected
Error: alexjs contains conflicting version recursive dependencies:
  openssl@3, openssl@1.1
...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be reverted or ignored

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, it should be fixed.

@branchvincent branchvincent added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 19, 2021
@branchvincent
Copy link
Member

Build failure on 10.14:

../deps/v8/src/regexp/regexp-parser.cc:248:8: note: declared private here
  bool Parse(RegExpCompileData* result);
       ^
4 errors generated.
make[1]: *** [/private/tmp/node-20211020-32473-pe84bw/node-v17.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/regexp/regexp-parser.o] Error 1

Others

==> Testing bcoin
==> /usr/local/opt/node/bin/node /private/tmp/bcoin-test-20211020-9008-1as7lc2/script.js
/usr/local/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:109
      throw e;
      ^

Error: Module did not self-register: '/usr/local/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.

Linux

==> brew linkage --test jupyterlab
==> FAILED
Missing libraries:
  unexpected (libffi.so.7)

@derrabus derrabus mentioned this pull request Oct 20, 2021
@iMichka
Copy link
Member

iMichka commented Oct 20, 2021

I opened a PR to fix jupyterlab: #87665

@derrabus
Copy link
Contributor

Rebase is needed now that #87647 has been merged.

@derrabus
Copy link
Contributor

Node 17.0.1 has been released: https://github.com/nodejs/node/releases/tag/v17.0.1

@branchvincent branchvincent changed the title node 17.0.0 node 17.0.1 Oct 20, 2021
@SMillerDev
Copy link
Member

bcoin apparently needs an older node on ARM

 ==> /opt/homebrew/opt/node/bin/node /private/tmp/bcoin-test-20211020-82610-6q7pvw/script.js
/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:109
      throw e;
      ^

Error: Module did not self-register: '/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.
    at Object.Module._extensions..node (node:internal/modules/cjs/loader:1177:18)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at bindings (/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:98:17)
    at Object.<anonymous> (/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/lib/native/binding.js:14:33)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1147:10)
    at Module.load (node:internal/modules/cjs/loader:975:32) {
  code: 'ERR_DLOPEN_FAILED'
}

@carlocab
Copy link
Member

carlocab commented Oct 21, 2021

I think it needs an older node everywhere. Should we add a node@16? I think that's an LTS release. EOL is in 2024: https://nodejs.org/en/about/releases/

@SMillerDev
Copy link
Member

Sounds good, I just didn't have the other results yet

@carlocab
Copy link
Member

snowpack also failed on Big Sur. Hoping it was just a fluke.

derekschinke and others added 3 commits October 22, 2021 02:31
SMillerDev
SMillerDev previously approved these changes Oct 22, 2021
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, jupyterlab is being fixed elsewhere.

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @SMillerDev bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review October 22, 2021 09:44

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants