-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datafusion 5.0 (new formula) #88184
datafusion 5.0 (new formula) #88184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jimexist. Just a few suggestions.
Formula/datafusion.rb
Outdated
|
||
test do | ||
(testpath/"datafusion_test.sql").write("select cos(1.0+2.1);") | ||
system "#{bin}/datafusion-cli", "-f", "datafusion_test.sql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check some output here?
add Apache Arrow Datafusion engine's CLI i.e. datafusion-cli to brew
9828d0b
to
87b45c4
Compare
Looks like you picked up a bunch of extra commits here. Please do
Edit: Never mind, I see you've done this already. |
add Apache Arrow Datafusion engine's CLI i.e. datafusion-cli to brew
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?