Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datafusion 5.0 (new formula) #88184

Closed
wants to merge 1 commit into from
Closed

Conversation

jimexist
Copy link
Contributor

@jimexist jimexist commented Oct 28, 2021

add Apache Arrow Datafusion engine's CLI i.e. datafusion-cli to brew

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 28, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jimexist. Just a few suggestions.

Formula/datafusion.rb Outdated Show resolved Hide resolved

test do
(testpath/"datafusion_test.sql").write("select cos(1.0+2.1);")
system "#{bin}/datafusion-cli", "-f", "datafusion_test.sql"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check some output here?

add Apache Arrow Datafusion engine's CLI i.e. datafusion-cli to brew
@carlocab
Copy link
Member

carlocab commented Oct 28, 2021

Looks like you picked up a bunch of extra commits here. Please do

cd "$(brew --repository homebrew/core)"
git checkout add-datafusion
git fetch origin
git rebase origin/master
git push --force

Edit: Never mind, I see you've done this already.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@jimexist jimexist deleted the add-datafusion branch October 28, 2021 15:22
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants