Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datafusion 6.0.0 #89562

Closed
wants to merge 1 commit into from
Closed

Conversation

jimexist
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue labels Nov 17, 2021
@jimexist
Copy link
Contributor Author

oops i guess in building ballista it requires rustfmt to be present. cc @houqp

@@ -16,8 +16,14 @@ class Datafusion < Formula
end

depends_on "rust" => :build
# building ballista requires installing rustfmt
depends_on "rustup-init" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the wrong way to go about it. We should instead add a rustfmt formula and make that a build dependency here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let me try to do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You can open a separate PR for rustfmt to keep things simple here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me try that in #89599

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the advice, this is now updated (and with minimal changes thanks to rustfmt)

@jimexist
Copy link
Contributor Author

@houqp I think we need to (in later releases) update the script so that the tagged commit won't have version including -SNAPSHOT

@houqp
Copy link

houqp commented Nov 18, 2021

oops i guess in building ballista it requires rustfmt to be present.

Interesting, do you know how it got pulled in? I certainly didn't expect this.

@houqp I think we need to (in later releases) update the script so that the tagged commit won't have version including -SNAPSHOT

Good call 👍 Will add this to the automation.

@jimexist jimexist force-pushed the bump-datafusion-6.0.0 branch from cd8ddcb to 8203c7b Compare November 18, 2021 14:17
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@jimexist jimexist deleted the bump-datafusion-6.0.0 branch November 19, 2021 02:12
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants