Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.57.0 + apply patch to fix duplicate object file bug #90103

Closed
wants to merge 2 commits into from

Conversation

carlocab
Copy link
Member

Having multiple object files with the same name upsets libtool and
breaks the librsvg build. See #85278.

@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 28, 2021
@BrewTestBot BrewTestBot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Nov 28, 2021
@carlocab carlocab mentioned this pull request Nov 28, 2021
@carlocab
Copy link
Member Author

librsvg built on Monterey ARM. We did get these failures:

Error: 7 failed steps!
brew install --build-from-source aws-google-auth
brew install --build-from-source buku
brew test --retry --verbose bzt
brew install --build-from-source charm-tools
brew fetch --build-from-source --retry imgproxy
brew fetch --build-from-source --retry moc
brew install --build-from-source theharvester

But I think we saw these on the previous Rust PR too.

@carlocab
Copy link
Member Author

ARM Big Sur has been building pandoc-plot for about 14 hours now. Probably stuck. Going to kill it.

@BrewTestBot
Copy link
Member

@carlocab bottle request for signal-cli failed.

@carlocab
Copy link
Member Author

carlocab commented Dec 1, 2021

A number of the Big Sur failures are probably from LLVM ERROR: IO failure on output stream: No space left on device

@carlocab
Copy link
Member Author

carlocab commented Dec 1, 2021

12-x86_64 is still pending and there are no dependent failures on Linux. Here's a summary of the rest:

All (except 12 and Linux):

brew install --build-from-source aws-google-auth
brew install --build-from-source buku
brew test --retry --verbose bzt
brew install --build-from-source charm-tools
brew fetch --build-from-source --retry imgproxy
brew fetch --build-from-source --retry moc
brew install --build-from-source theharvester

11-arm64, 11, 10.15:

brew install --build-from-source audacious
brew install --build-from-source evince
brew install --build-from-source ford

11-arm64, 11:

brew install --build-from-source pc6001vx
brew install --build-from-source root

11, 10.15:

brew install --build-from-source deno
brew install --build-from-source gjs
brew install --build-from-source pwntools
brew install --build-from-source robot-framework
brew install --build-from-source sail
brew install --build-from-source snapcraft
brew install --build-from-source sslyze
brew install --build-from-source stormssh
brew install --build-from-source svtplay-dl
brew install --build-from-source termius
brew install --build-from-source vice
brew install --build-from-source ykman

12-arm64 only:

brew install --build-from-source chronograf
brew install --build-from-source pandoc-plot
brew test --retry --verbose watchexec

11 only:

brew install --build-from-source openstackclient

10.15 only:

brew install --build-from-source qmmp

@carlocab
Copy link
Member Author

carlocab commented Dec 1, 2021

@carlocab
Copy link
Member Author

carlocab commented Dec 2, 2021

12:

Error: 24 failed steps!
brew install --build-from-source aws-google-auth
brew install --build-from-source buku
brew test --retry --verbose bzt
brew install --build-from-source charm-tools
brew fetch --build-from-source --retry imgproxy
brew install --build-from-source magic-wormhole
brew install --build-from-source mitmproxy
brew fetch --build-from-source --retry moc
brew install --build-from-source molecule
brew install --build-from-source moto
brew install --build-from-source mycli
brew install --build-from-source oci-cli
brew install --build-from-source ocrmypdf
brew install --build-from-source openstackclient
brew install --build-from-source pwntools
brew install --build-from-source robot-framework
brew install --build-from-source sail
brew install --build-from-source snapcraft
brew install --build-from-source sslyze
brew install --build-from-source stormssh
brew install --build-from-source svtplay-dl
brew install --build-from-source termius
brew install --build-from-source theharvester
brew install --build-from-source ykman

New:

@carlocab
Copy link
Member Author

carlocab commented Dec 2, 2021

@Homebrew/core any idea what's going on here? It looks to me like most of the failures are actually Python issues, rather than anything related to Rust.

@Bo98
Copy link
Member

Bo98 commented Dec 2, 2021

Indeed it's not a Rust issue: pypa/flit#451

@Bo98
Copy link
Member

Bo98 commented Dec 2, 2021

Rust 1.57.0 is out. Want to roll that together with this?

(Patch will likely still be necessary as it would have landed too late.)

@EricFromCanada
Copy link
Member

Also, Rust 1.57.0 is out.

@carlocab
Copy link
Member Author

carlocab commented Dec 2, 2021

Cool, let's do that. (Is the self-hosted Linux runner free?)

@Bo98
Copy link
Member

Bo98 commented Dec 2, 2021

Is the self-hosted Linux runner free?

No, it's doing Node 17.

I'll have a look at some of the current failures in the meantime.

@carlocab carlocab changed the title rust: apply patch to fix duplicate object file bug rust 1.57.0 + apply patch to fix duplicate object file bug Dec 2, 2021
@carlocab carlocab removed the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 2, 2021
@Bo98
Copy link
Member

Bo98 commented Dec 2, 2021

Bootstrap should be updated to 1.56.1 (2021-11-01).

(and change the .txt in the comment to .json)

@BrewTestBot BrewTestBot added the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 2, 2021
@carlocab carlocab removed the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 2, 2021
@carlocab
Copy link
Member Author

carlocab commented Dec 3, 2021

Opened #90320 to fix the Linux failure.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 8, 2021
@branchvincent
Copy link
Member

setuptools-rust removed it's dependency on tomli PyO3/setuptools-rust#200, so those issues should be fixed

Having multiple object files with the same name upsets libtool and
breaks the librsvg build. See Homebrew#85278.
@branchvincent
Copy link
Member

let's re-run this, looks like most errors have been addressed

@branchvincent branchvincent added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2021
This was referenced Dec 31, 2021
@carlocab
Copy link
Member Author

carlocab commented Jan 2, 2022

I don't think we can do much about the remaining failures, and I don't think they're related either. Will merge this later today unless there are any objections.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 2, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the rust-librsvg branch January 2, 2022 12:49
@BrewTestBot
Copy link
Member

@carlocab bottle request for librsvg failed.

@carlocab
Copy link
Member Author

carlocab commented Jan 2, 2022

@carlocab bottle request for librsvg failed.

It... didn't work?

libtool:   error: object name conflicts in archive: .libs/librsvg-2.lax/librsvg_c_api.a//private/tmp/librsvg-20220102-73256-kibl4c/librsvg-2.50.7/./.libs/librsvg_c_api.a

But it was built during the dependent tests and didn't fail. Weird.

Edit: Ah, it was installed from a bottle: https://github.com/Homebrew/homebrew-core/runs/4664093679?check_suite_focus=true#step:8:7637

I don't understand why, since it's in the source dependents list. https://github.com/Homebrew/homebrew-core/runs/4664093679?check_suite_focus=true#step:8:242

@BrewTestBot
Copy link
Member

@carlocab bottle request for suricata failed.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants