-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust 1.57.0 + apply patch to fix duplicate object file bug #90103
Conversation
But I think we saw these on the previous Rust PR too. |
ARM Big Sur has been building |
A number of the Big Sur failures are probably from |
12-x86_64 is still pending and there are no dependent failures on Linux. Here's a summary of the rest: All (except 12 and Linux):
11-arm64, 11, 10.15:
11-arm64, 11:
11, 10.15:
12-arm64 only:
11 only:
10.15 only:
|
|
12:
New: |
@Homebrew/core any idea what's going on here? It looks to me like most of the failures are actually Python issues, rather than anything related to Rust. |
Indeed it's not a Rust issue: pypa/flit#451 |
Rust 1.57.0 is out. Want to roll that together with this? (Patch will likely still be necessary as it would have landed too late.) |
Also, Rust 1.57.0 is out. |
Cool, let's do that. (Is the self-hosted Linux runner free?) |
No, it's doing Node 17. I'll have a look at some of the current failures in the meantime. |
f08072e
to
11b4cc4
Compare
11b4cc4
to
548a4cb
Compare
Bootstrap should be updated to 1.56.1 (2021-11-01). (and change the .txt in the comment to .json) |
548a4cb
to
db5286e
Compare
Opened #90320 to fix the Linux failure. |
|
Having multiple object files with the same name upsets libtool and breaks the librsvg build. See Homebrew#85278.
let's re-run this, looks like most errors have been addressed |
db5286e
to
6ba4ac2
Compare
I don't think we can do much about the remaining failures, and I don't think they're related either. Will merge this later today unless there are any objections. |
It... didn't work?
But it was built during the dependent tests and didn't fail. Weird. Edit: Ah, it was installed from a bottle: https://github.com/Homebrew/homebrew-core/runs/4664093679?check_suite_focus=true#step:8:7637 I don't understand why, since it's in the source dependents list. https://github.com/Homebrew/homebrew-core/runs/4664093679?check_suite_focus=true#step:8:242 |
Having multiple object files with the same name upsets libtool and
breaks the librsvg build. See #85278.