-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.10: remove include_dirs, library_dirs from distutils.cfg #91043
Conversation
I'd rather the include/library directories were all dealt with at the same time rather than removing a random one. I definitely agree they should go, even if I'm a little cautious at what we're potentially breaking here. (I'm aware of the future setuptools issue in regards to
More of a side note this, but this is pretty much specific to your use of the compiler-level |
OK, I have made this change |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
ping? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Apologies for the late response. This has been merged as a part of 3.10.2, but I forgot to mention this issue in the commit. We decided it was best to remove I'm not entirely sure yet what we'll backport to Python 3.9 and earlier. We could backport this bit if needed, but there'll still be some form of |
Thanks for the update! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Homebrew's python3 installs
distutils.cfg
, which injects include and library paths into the build of every user package. The injected directories appear at the beginning of the paths and hence take precedence over paths configured by the packages' build systems. (We encountered this in the SageMath project in https://trac.sagemath.org/ticket/31335; our workaround is to useSETUPTOOLS_USE_DISTUTILS=local
, thus disabling homebrew's copy of distutils.)In this PR, we remove one item from these paths, with the eventual goal of removing
distutils.cfg
altogether.distutils.cfg
is an outdated and problematic mechanism, which is moreover set to be ineffective for packages that usesetuptools
whensetuptools
(again) makesSETUPTOOLS_USE_DISTUTILS=local
the standard behavior (pypa/setuptools#2896). See also #76621.