-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensearch 1.2.2 #91468
opensearch 1.2.2 #91468
Conversation
Coming from opensearch-project/opensearch-build#38 |
@dblock what you suggest makes sense. Is there another formulae you know of that downloads a binary distribution that could be used as an example? I've never written a formulae before, so any pointers would be appreciated. |
Me neither ;) For opensearch it's pretty straightforward to get started though. |
Can we update opensearch to 1.2.2 per this PR? |
We don't allow such things in homebrew core. The formula should be built from the source. |
I see that looking at other formula, thanks. Is it written up somewhere? (I’m new here, apologies). What’s the guidance for dependencies? This build downloads the kitchen sink from maven for example. Those are binary dependencies, not built from source. |
Something like this https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae?
It's ok to use maven / npm / go modules / whatever else that freezes the exact version of source code dependencies with their checksums (ok, maybe "whatever" is a too broad term, but you get the idea). |
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr
.