Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm@3.9 (new formula) #9414

Closed
wants to merge 2 commits into from
Closed

llvm@3.9 (new formula) #9414

wants to merge 2 commits into from

Conversation

tmcdonell
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Versioned install of LLVM-3.9. Useful for people who need to install multiple versions of LLVM simultaneously (like me), or who need to install a specific version (also useful in documentation).

LLVM-4.0 is currently in RC and scheduled to be released in a few days. Once that is out we can bump the llvm.rb formula and LLVM-3.9 will still be available via this formula.

I included the fix to llvm@3.8 in this PR, since that was causing problems installing multiple versions simultaneously, but I could probably split that out. I currently have llvm@3.7, llvm@3.8, and llvm@3.9 formula installed and they seem to be working together nicely.

A few files were installed into the wrong location in the keg, resulting in them being symlinked into `brew --prefix` without the version suffix. This conflicts with other versioned installations of LLVM. For example, we had:

> `brew --prefix`/bin/scan-view
> `brew --prefix`/share/clang/...

instead of:

> `brew --prefix`/bin/scan-view-3.8
> `brew --prefix`/share/clang-3.8/...
Versioned install of LLVM-3.9, where executables have the "-3.9" suffix. Particularly useful for users who require multiple versions simultaneously, or who need to install a specific version.
@ilovezfs
Copy link
Contributor

The current formula is already 3.9.x, so at most we'd consider adding an alias.

@ilovezfs ilovezfs closed this Jan 29, 2017
@tmcdonell
Copy link
Contributor Author

@ilovezfs As I mentioned in the comment, LLVM is about to land 4.0, so this is still necessary. At worst I am a few days early with the PR.

Additionally, for my own use can, LLVM is one of the dependencies of my software and it requires a specific version to be installed. It is much easier to write in the documentation/installation instructions brew install llvm@3.9; rather than brew install llvm; brew link --force llvm and hope for the best. I think this is a valid use case.

@ilovezfs
Copy link
Contributor

which is why I said we'd accept a PR for an alias

@ilovezfs
Copy link
Contributor

See #8945.

@MikeMcQuaid
Copy link
Member

I included the fix to llvm@3.8 in this PR, since that was causing problems installing multiple versions simultaneously, but I could probably split that out.

Yeh, a separate PR would be best for this, thanks.

As I mentioned in the comment, LLVM is about to land 4.0, so this is still necessary. At worst I am a few days early with the PR.

I'd recommend creating a PR for both LLVM 4.0 and LLVM@3.9 in the same one.

@tmcdonell
Copy link
Contributor Author

@MikeMcQuaid sure, I'll create a separate PR for that.

I appreciate your courtesy to actually read the commit message. Thanks.

@ilovezfs
Copy link
Contributor

Cute.

@tmcdonell tmcdonell deleted the llvm@3.9 branch January 30, 2017 02:04
@MikeMcQuaid
Copy link
Member

I appreciate your courtesy to actually read the commit message. Thanks.

GitHub's UI is PR-focused rather than commit-focused and Homebrew's maintainers are busy people so it's best to put information you need to be read in the PR message as well as the commit message.

@bfontaine bfontaine added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 30, 2017
@killerswan killerswan mentioned this pull request Mar 16, 2017
@ilovezfs ilovezfs mentioned this pull request Mar 17, 2017
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants