Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman 4.0.2 #95318

Closed
wants to merge 1 commit into from
Closed

podman 4.0.2 #95318

wants to merge 1 commit into from
+79 −8

Conversation

ashley-cui
Copy link
Contributor

@ashley-cui ashley-cui commented Feb 17, 2022 •
edited
Loading

[DO NOT MERGE]

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Feb 17, 2022
@ashley-cui
Copy link
Contributor Author

ashley-cui commented Feb 17, 2022 •
edited
Loading

[DO NOT MERGE]

If any maintainer can put a do-not-merge label on it, that would be great.

Opening this pull request so others will not try to get this in, but please do not merge. Podman 4.0.0 needs Podman 4.0.0 inside its VM image. (Chicken and the egg, we need to release 4.0.0 but in order to release 4.0.0 for Mac, we need 4.0.0 in the vm already) Without it, this will break Podman entirely due to API versioning. I will update you all when we have Podman in our VM image and will be safe to merge.

@ashley-cui ashley-cui changed the title podman 4.0.0 podman 4.0.0 [DO NOT MERGE] Feb 17, 2022
@ashley-cui ashley-cui changed the title podman 4.0.0 [DO NOT MERGE] podman 4.0.1 [DO NOT MERGE] Feb 23, 2022
@ashley-cui
Copy link
Contributor Author

Same issue with 4.0.1.

@Andrewpk
Copy link

@ashley-cui it appears podman 4.0.0 and 4.0.1 have been released, is the do not merge tag still relevant?

@ashley-cui
Copy link
Contributor Author

ashley-cui commented Feb 23, 2022 •
edited
Loading

it appears podman 4.0.0 and 4.0.1 have been released, is the do not merge tag still relevant?

@Andrewpk yes, still do-not-merge.

@weyert
Copy link

weyert commented Feb 24, 2022

@ashley-cui Is there any way we could you to get this PR merged? Pretty interested in trying out Podman 4 on my Mac :)

@dlabreu
Copy link

dlabreu commented Feb 24, 2022

+1 here. Hoping to have this on my mac soon, as this release fixes 11507 Thanks.

@ashley-cui
Copy link
Contributor Author

We're looking at sometime next week, as we have to create and test the images.

@weyert @dlabreu

@viinhpham
Copy link

Looking forward to see this merge. need to check the mounting ability

@cho-m cho-m mentioned this pull request Feb 27, 2022
Closed
@matheussouza9 matheussouza9 mentioned this pull request Feb 27, 2022
Closed
@zeha
Copy link
Contributor

zeha commented Mar 1, 2022

New VM images appear to have podman 4.0.x already.

@ashley-cui
Copy link
Contributor Author

@zeha, not quite yet. VM image is podman 4.0.0-dev, which was a RC for podman. podman will still not work ATM with that VM image.

@ashley-cui ashley-cui changed the title podman 4.0.1 [DO NOT MERGE] podman 4.0.2 [DO NOT MERGE] Mar 2, 2022
@SMillerDev
Copy link
Member

Is it possible to link the upstream issue where that's being fixed?

@baude
Copy link
Contributor

baude commented Mar 2, 2022

the vm images are not an issue. none what so ever. the issue is we are trying to see if we can enable volume mounting for macos early. we are to make a decision midweek (todayish). hang tight, it is coming.

@baude
Copy link
Contributor

baude commented Mar 4, 2022

would folks be willing to do some pre-release testing based on a tap for me ?

@baude
Copy link
Contributor

baude commented Mar 4, 2022

.. and if so, can you get on irc , libera? #podman? there is also a matrix bridge. https://podman.io/community/#slack-irc-matrix-and-discord

@dlabreu
Copy link

dlabreu commented Mar 4, 2022

would folks be willing to do some pre-release testing based on a tap for me ?

@baude I am more than happy to do some testing. Will jump in on irc and take on from there. Thanks

@baude
Copy link
Contributor

baude commented Mar 5, 2022

would folks please try my tap? well will be taking my tap and merging it with @ashley-cui

$ brew uninstall podman
$ brew uninstall qemu
$ brew tap baude/podman
$ brew install baude/podman/podman

@dlabreu
Copy link

dlabreu commented Mar 6, 2022

would folks please try my tap? well will be taking my tap and merging it with @ashley-cui

$ brew uninstall podman
$ brew uninstall qemu
$ brew tap baude/podman
$ brew install baude/podman/podman

@baude I am trying out this week and will give you feed back.
All running here!
podman version
Client: Podman Engine
Version: 4.0.2
API Version: 4.0.2
Go Version: go1.17.8

Built: Wed Mar 2 16:04:36 2022
OS/Arch: darwin/amd64

Server: Podman Engine
Version: 4.0.2
API Version: 4.0.2
Go Version: go1.16.14

Built: Thu Mar 3 16:56:56 2022
OS/Arch: linux/amd64

@vashirov
Copy link
Contributor

vashirov commented Mar 6, 2022

@baude

Client:       Podman Engine
Version:      4.0.2
API Version:  4.0.2
Go Version:   go1.17.8

Built:      Wed Mar  2 15:04:36 2022
OS/Arch:    darwin/arm64

Server:       Podman Engine
Version:      4.0.2
API Version:  4.0.2
Go Version:   go1.16.14

Built:      Thu Mar  3 15:58:50 2022
OS/Arch:    linux/arm64

With fedora-coreos-35.20220305.dev.0-qemu.aarch64.qcow2.xz it seems to work fine for me. I'm able to run run my usual containers (rootless with and without systemd). Let me know if you want to run any specific tests.

Thanks!

@baude
Copy link
Contributor

baude commented Mar 6, 2022 •
edited
Loading

most certainly try volume mounts ... they are r/n a bit different than you might be used to, because I had to squeeze it in there ... but something like podman machine init -v /Users/brentbaude/foo:/home/core/foobar should now work. In addition, then try something like podman run -it --rm -v /home/core/foobar:/foobar alpine cat /foobar/somefile. In particular, Apple Silicon would be nice. But thumbs up for Intel darwin too!

@jtymes
Copy link

jtymes commented Mar 6, 2022

Guessing you meant podman machine init -v ...?

I tested out a volume mount with a basic nginx configuration and it's working on Apple Silicon.

@willcohen willcohen mentioned this pull request Mar 8, 2022
Closed
10 tasks
@baude
Copy link
Contributor

baude commented Mar 10, 2022

hey folks, ashley is on PTO now for a bit .. I'm going to push her work over the finish line. would you prefer I open a new PR to do so?

@SMillerDev
Copy link
Member

You will need to open a new PR to patch qemu. But this one can stay for podman if you're allowed to modify the branch.

@baude baude mentioned this pull request Mar 10, 2022
Closed
4 tasks
baude added a commit to baude/homebrew-core that referenced this pull request Mar 11, 2022
@baude
qemu: add 9p support for Darwin
a6a99c8 
qemu: add 9p support for Darwin

Qemu already has support for 9p in Linux.  Adding this for MacOS users
will bring them into parity for 9p support.

This replaces Ashley's Homebrew#95318

Signed-off-by: Brent Baude <bbaude@redhat.com>
BrewTestBot pushed a commit that referenced this pull request Mar 13, 2022
@baude @BrewTestBot
qemu: add 9p support for Darwin
a70f2f6 
qemu: add 9p support for Darwin

Qemu already has support for 9p in Linux.  Adding this for MacOS users
will bring them into parity for 9p support.

This replaces Ashley's #95318

Signed-off-by: Brent Baude <bbaude@redhat.com>
@baude baude mentioned this pull request Mar 14, 2022
Closed
6 tasks
baude added a commit to baude/homebrew-core that referenced this pull request Mar 14, 2022
@baude
podman: new 4.0.2 release
04af99c 
Update to 4.0.2 release for podman.

Replaces Homebrew#95318

Signed-off-by: Brent Baude <bbaude@redhat.com>
@trevor-viljoen
Copy link

What is the status here?

@SMillerDev
Copy link
Member

Closing in favor of the replacement

@SMillerDev SMillerDev closed this Mar 15, 2022
BrewTestBot pushed a commit that referenced this pull request Mar 15, 2022
@baude @BrewTestBot
podman: new 4.0.2 release
214b600 
Update to 4.0.2 release for podman.

Replaces #95318

Closes #96844.

Signed-off-by: Brent Baude <bbaude@redhat.com>
Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@rgov
Copy link
Contributor

rgov commented Mar 15, 2022

The replacement being #96844 which was merged 5 hours ago.

@chenrui333 chenrui333 added superseded PR was replaced by another PR and removed do not merge labels Apr 1, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label May 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2022
@ashley-cui ashley-cui deleted the podman4.0 branch October 4, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude baude left review comments

@willcohen willcohen willcohen left review comments

@SMillerDev SMillerDev SMillerDev left review comments

@LionsAd LionsAd LionsAd left review comments

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.