Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsmf: fix build on Apple Silicon and deprecate #98351

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 1, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Apr 1, 2022
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added no ARM bottle Formula has no ARM bottle labels Apr 1, 2022
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Apr 1, 2022
@cho-m cho-m added license License PRs ready to merge PR can be merged once CI is green labels Apr 1, 2022
@SMillerDev
Copy link
Member

Can we submit this patch upstream?

@cho-m
Copy link
Member Author

cho-m commented Apr 2, 2022

Can we submit this patch upstream?

Not sure if upstream is still alive:

@SMillerDev
Copy link
Member

Can you also add deprecation then? Or does it still have dependencies?

@cho-m cho-m changed the title libsmf: fix build on Apple Silicon libsmf: fix build on Apple Silicon and deprecate Apr 2, 2022
@BrewTestBot BrewTestBot added the formula deprecated Formula deprecated label Apr 2, 2022
@cho-m
Copy link
Member Author

cho-m commented Apr 2, 2022

Can you also add deprecation then? Or does it still have dependencies?

No usage in other formulae. Added deprecation and URLs to GitHub repos.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the libsmf-m1 branch April 2, 2022 22:10
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles formula deprecated Formula deprecated license License PRs no ARM bottle Formula has no ARM bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants