Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpfi 1.5.4 #98522

Closed
wants to merge 1 commit into from
Closed

mpfi 1.5.4 #98522

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 4, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Previous attempt #39816.
GitHub does have a number of commits in March 2022, so seeing if possible to build again.

Will note that although make worked for me, make check failed on 3 tests (trec_sqrt, texp10, and tdiv_ext).

Wanted to check output on other OS.

@cho-m cho-m added in progress Stale bot should stay away CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 4, 2022

depends_on "gmp"
depends_on "mpfr"

def install
system "./configure", "--disable-dependency-tracking", "--prefix=#{prefix}"
system "./autogen.sh" if build.head?
system "./configure", *std_configure_args
system "make"
system "make", "check"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could disable the make check to ignore test failures. Not sure what is exact issue causing segfaults on 2 tests and 1-2 other test failures. Remaining 150+ tests all pass.

@cho-m cho-m force-pushed the bump-mpfi-1.5.4 branch from 62eed6e to 4511925 Compare April 22, 2022 01:47
@cho-m cho-m removed the in progress Stale bot should stay away label May 4, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 25, 2022
@github-actions github-actions bot closed this Jun 1, 2022
@cho-m cho-m mentioned this pull request Aug 3, 2022
22 tasks
@cho-m cho-m deleted the bump-mpfi-1.5.4 branch September 18, 2022 06:40
@cho-m cho-m added the not merged PR was closed without being merged (and may need to be revisited) label Sep 19, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
@chenrui333
Copy link
Member

#114715

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. not merged PR was closed without being merged (and may need to be revisited) outdated PR was locked due to age stale No recent activity superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants