Allow ARM on macOS #373

fxcoudert · 2020-12-12T10:39:35Z

Although we're not entirely there yet, the time for Apple Silicon support is nearing. I've had a look at the installer script to see what is needed there.

fxcoudert · 2020-12-12T10:57:15Z

Around line 425, there is:

directories=(bin etc include lib sbin share var opt
             share/zsh share/zsh/site-functions
             var/homebrew var/homebrew/linked
             Cellar Caskroom Homebrew Frameworks)
mkdirs=()
for dir in "${directories[@]}"; do
  if ! [[ -d "${HOMEBREW_PREFIX}/${dir}" ]]; then
    mkdirs+=("${HOMEBREW_PREFIX}/${dir}")
  fi
done

I think the Homebrew directory here is an error. HOMEBREW_REPOSITORY should be created with a different logic.

fxcoudert · 2020-12-12T11:03:03Z

Running this version on Apple Silicon currently fails because we're not giving /opt/homebrew the right ownership. It gets root:wheel, which is not appropriate. Whatever else happens, we always need to be owners of HOMEBREW_REPOSITORY.

brewadmin@administrators-Mac-5 ~ % bash ./install.sh    
==> This script will install:
/opt/homebrew/bin/brew
/opt/homebrew/share/doc/homebrew
/opt/homebrew/share/man/man1/brew.1
/opt/homebrew/share/zsh/site-functions/_brew
/opt/homebrew/etc/bash_completion.d/brew
/opt/homebrew
==> The following new directories will be created:
/opt/homebrew/bin
/opt/homebrew/etc
/opt/homebrew/include
/opt/homebrew/lib
/opt/homebrew/sbin
/opt/homebrew/share
/opt/homebrew/var
/opt/homebrew/opt
/opt/homebrew/share/zsh
/opt/homebrew/share/zsh/site-functions
/opt/homebrew/var/homebrew
/opt/homebrew/var/homebrew/linked
/opt/homebrew/Cellar
/opt/homebrew/Caskroom
/opt/homebrew/Homebrew
/opt/homebrew/Frameworks

Press RETURN to continue or any other key to abort
==> /usr/bin/sudo /bin/mkdir -p /opt/homebrew
==> /usr/bin/sudo /usr/sbin/chown root:wheel /opt/homebrew
==> /usr/bin/sudo /bin/mkdir -p /opt/homebrew/bin /opt/homebrew/etc /opt/homebrew/include /opt/homebrew/lib /opt/homebrew/sbin /opt/homebrew/share /opt/homebrew/var /opt/homebrew/opt /opt/homebrew/share/zsh /opt/homebrew/share/zsh/site-functions /opt/homebrew/var/homebrew /opt/homebrew/var/homebrew/linked /opt/homebrew/Cellar /opt/homebrew/Caskroom /opt/homebrew/Homebrew /opt/homebrew/Frameworks
==> /usr/bin/sudo /bin/chmod g+rwx /opt/homebrew/bin /opt/homebrew/etc /opt/homebrew/include /opt/homebrew/lib /opt/homebrew/sbin /opt/homebrew/share /opt/homebrew/var /opt/homebrew/opt /opt/homebrew/share/zsh /opt/homebrew/share/zsh/site-functions /opt/homebrew/var/homebrew /opt/homebrew/var/homebrew/linked /opt/homebrew/Cellar /opt/homebrew/Caskroom /opt/homebrew/Homebrew /opt/homebrew/Frameworks
==> /usr/bin/sudo /usr/sbin/chown brewadmin /opt/homebrew/bin /opt/homebrew/etc /opt/homebrew/include /opt/homebrew/lib /opt/homebrew/sbin /opt/homebrew/share /opt/homebrew/var /opt/homebrew/opt /opt/homebrew/share/zsh /opt/homebrew/share/zsh/site-functions /opt/homebrew/var/homebrew /opt/homebrew/var/homebrew/linked /opt/homebrew/Cellar /opt/homebrew/Caskroom /opt/homebrew/Homebrew /opt/homebrew/Frameworks
==> /usr/bin/sudo /usr/bin/chgrp admin /opt/homebrew/bin /opt/homebrew/etc /opt/homebrew/include /opt/homebrew/lib /opt/homebrew/sbin /opt/homebrew/share /opt/homebrew/var /opt/homebrew/opt /opt/homebrew/share/zsh /opt/homebrew/share/zsh/site-functions /opt/homebrew/var/homebrew /opt/homebrew/var/homebrew/linked /opt/homebrew/Cellar /opt/homebrew/Caskroom /opt/homebrew/Homebrew /opt/homebrew/Frameworks
==> Downloading and installing Homebrew...
/opt/homebrew/.git: Permission denied
Failed during: git init -q

MikeMcQuaid

Looks good so far!

install.sh

MikeMcQuaid · 2020-12-14T12:35:07Z

I think the Homebrew directory here is an error. HOMEBREW_REPOSITORY should be created with a different logic.

Yes, that could reference HOMEBREW_REPOSITORY if needed or just be removed perhaps.

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

fxcoudert · 2020-12-15T22:28:48Z

I've tested on ARM and Intel macOS. I'd like to have some Linux testing, but otherwise I think this is complete and ready for review.

sjackman · 2020-12-15T23:29:56Z

I'd like to have some Linux testing, but otherwise I think this is complete and ready for review.

I gave it a quick test on Linux in /home/linuxbrew/.linuxbrew with and without sudo available, and it worked for me.

MikeMcQuaid

Looks good to me! Let's hold off merging until we're able to announce we "support" this (i.e. we have a non-trivial number of bottles).

billinghamj · 2020-12-17T13:07:00Z

I think this is great, as really a shockingly large amount of stuff "just works" now - it's really impressive how fast that has happened.

But I wonder if you might want to consider describing it as more partial support, or support with significant caveats? As some not-insignificant proportion of formulae will likely not be compatible for a long time, if ever. So setting user expectations in some form may help?

MikeMcQuaid · 2020-12-17T15:07:17Z

But I wonder if you might want to consider describing it as more partial support, or support with significant caveats? As some not-insignificant proportion of formulae will likely not be compatible for a long time, if ever. So setting user expectations in some form may help?

Yup, that's the plan before we'd merge this 👍🏻

fxcoudert · 2020-12-23T22:42:06Z

We have passed 1000 ARM bottles, and I would like to merge this and enable ARM testing on CI: Homebrew/homebrew-core#67577

MikeMcQuaid

Can we print some sort of disclaimer that there's still a lot of packages missing bottles and recommend Rosetta 2 for now? What's the state of brew doctor on a default ARM setup; might want to address/add to that too?

fxcoudert · 2020-12-24T13:04:04Z

Re. brew doctor: Homebrew/brew#10132

MikeMcQuaid · 2020-12-24T13:11:37Z

Re. brew doctor: Homebrew/brew#10132

👍🏻 to merge once that's merged.

fxcoudert · 2020-12-26T10:43:51Z

👍🏻 to merge once that's merged

@MikeMcQuaid I believe we need a version shipped, otherwise people will get brew doctor complaints

fxcoudert · 2020-12-26T16:59:36Z

I've opened a brew issue tracking Apple Silicon support, and stating our current level of support, here: Homebrew/brew#10152

richiksc · 2020-12-28T17:47:38Z

There's a new brew version released now with Homebrew/brew#10132 included. Can this be merged now?

fievelk · 2020-12-30T09:42:38Z

Just a quick note: since this PR got merged, I think it would be good to update the first lines of the instructions on https://docs.brew.sh/Installation (they only mention /usr/local for the script installation, while /opt/homebrew is also available now).

fxcoudert · 2020-12-30T09:54:34Z

@fievelk indeed, thank you for noticing! Homebrew/brew#10182

charliegroll · 2020-12-30T12:58:41Z

@fievelk @fxcoudert it also says that a 64-bit Intel CPU is required 😉

fxcoudert · 2020-12-30T13:01:45Z

@charliegroll my pull request also changes that part: Homebrew/brew#10182

nickoe · 2021-01-09T16:42:54Z

@fxcoudert Why does the HOMEBREW_PREFIX need to be different depending on arch?

fxcoudert · 2021-01-09T17:43:01Z

@nickoe see Homebrew/brew#9177

nickoe · 2021-01-09T18:09:52Z

@fxcoudert That issue does not really talk about why. I guess the closest answer is Homebrew/brew#9130 (comment)

But as lenlo mentions:

[...]
I am less happy with the heavy handed way /opt/homebrew suddenly got usurped for ARM binaries only -- even on x86 systems that will never have any ARM binaries on them.
[...]

But yet, that does not explain why they prefixes has to be different.

fxcoudert · 2021-01-09T18:35:51Z

In the initial phase of Apple Silicon migration, in order to avoid using the same prefix for both Intel and ARM binaries, we have two prefixes instead: /usr/local for Intel, and /opt/homebrew for Apple Silicon

Basically because not everything supports Apple Silicon, we need to have coexisting installations for Rosetta and native. Hence we cannot use /usr/local for ARM

nickoe · 2021-01-09T18:47:32Z

@fxcoudert but couldn't hat just be a subdir in the prefix?

sjackman · 2021-01-10T00:47:14Z

A subdirectory like /usr/local/arm was one of proposals considered, but /opt/homebrew was preferred by the majority.

richiksc · 2021-01-10T00:52:25Z

Off-topic, but I prefer /opt/homebrew as well, because it creates separation between binaries installed by Homebrew, and binaries installed manually to /usr/local/bin. If I ever wanted to delete all Homebrew installed binaries or in fact Homebrew itself, I can easily run rm -rf /opt/homebrew[/bin] without worrying about anything else installed to /usr/local.

sjackman · 2021-01-10T00:57:27Z

Homebrew on Linux uses /home/linuxbrew/.linuxbrew as the default prefix for this reason among others.

Allow ARM on macOS

6495de7

fxcoudert added the do not merge label Dec 12, 2020

Fix typo

ada666e

MikeMcQuaid reviewed Dec 14, 2020

View reviewed changes

install.sh Outdated Show resolved Hide resolved

fxcoudert and others added 3 commits December 15, 2020 23:06

Give HOMEBREW_REPOSITORY the right ownership

6d01f52

Make it clear ~/.linuxbrew is unsupported

95e9a3b

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

Do not symlink brew to itself

a156555

MikeMcQuaid approved these changes Dec 16, 2020

View reviewed changes

sjackman mentioned this pull request Dec 16, 2020

TSC Discussion: Default Homebrew flavour on Apple Silicon Homebrew/brew#9110

Closed

fxcoudert removed the do not merge label Dec 23, 2020

MikeMcQuaid reviewed Dec 24, 2020

View reviewed changes

AddoSolutions mentioned this pull request Dec 26, 2020

Apple Silicon support in Homebrew Homebrew/brew#10152

Closed

fxcoudert merged commit c2cfecf into master Dec 28, 2020

fxcoudert deleted the arm branch December 28, 2020 21:19

fievelk mentioned this pull request Jan 1, 2021

New location for fzf under macOS with ARM architecture thoughtbot/dotfiles#681

Closed

Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ARM on macOS #373

Allow ARM on macOS #373

fxcoudert commented Dec 12, 2020

fxcoudert commented Dec 12, 2020

fxcoudert commented Dec 12, 2020

MikeMcQuaid left a comment

MikeMcQuaid commented Dec 14, 2020

fxcoudert commented Dec 15, 2020

sjackman commented Dec 15, 2020

MikeMcQuaid left a comment

billinghamj commented Dec 17, 2020 •

edited

Loading

MikeMcQuaid commented Dec 17, 2020

fxcoudert commented Dec 23, 2020

MikeMcQuaid left a comment

fxcoudert commented Dec 24, 2020

MikeMcQuaid commented Dec 24, 2020

fxcoudert commented Dec 26, 2020

fxcoudert commented Dec 26, 2020

richiksc commented Dec 28, 2020

fievelk commented Dec 30, 2020 •

edited

Loading

fxcoudert commented Dec 30, 2020

charliegroll commented Dec 30, 2020

fxcoudert commented Dec 30, 2020

nickoe commented Jan 9, 2021

fxcoudert commented Jan 9, 2021

nickoe commented Jan 9, 2021

fxcoudert commented Jan 9, 2021

nickoe commented Jan 9, 2021

sjackman commented Jan 10, 2021

richiksc commented Jan 10, 2021

sjackman commented Jan 10, 2021

Allow ARM on macOS #373

Allow ARM on macOS #373

Conversation

fxcoudert commented Dec 12, 2020

fxcoudert commented Dec 12, 2020

fxcoudert commented Dec 12, 2020

MikeMcQuaid left a comment

Choose a reason for hiding this comment

MikeMcQuaid commented Dec 14, 2020

fxcoudert commented Dec 15, 2020

sjackman commented Dec 15, 2020

MikeMcQuaid left a comment

Choose a reason for hiding this comment

billinghamj commented Dec 17, 2020 • edited Loading

MikeMcQuaid commented Dec 17, 2020

fxcoudert commented Dec 23, 2020

MikeMcQuaid left a comment

Choose a reason for hiding this comment

fxcoudert commented Dec 24, 2020

MikeMcQuaid commented Dec 24, 2020

fxcoudert commented Dec 26, 2020

fxcoudert commented Dec 26, 2020

richiksc commented Dec 28, 2020

fievelk commented Dec 30, 2020 • edited Loading

fxcoudert commented Dec 30, 2020

charliegroll commented Dec 30, 2020

fxcoudert commented Dec 30, 2020

nickoe commented Jan 9, 2021

fxcoudert commented Jan 9, 2021

nickoe commented Jan 9, 2021

fxcoudert commented Jan 9, 2021

nickoe commented Jan 9, 2021

sjackman commented Jan 10, 2021

richiksc commented Jan 10, 2021

sjackman commented Jan 10, 2021

billinghamj commented Dec 17, 2020 •

edited

Loading

fievelk commented Dec 30, 2020 •

edited

Loading