Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

The wxmac formula should not default to monolithic builds #26624

Closed
asabil opened this issue Feb 11, 2014 · 5 comments
Closed

The wxmac formula should not default to monolithic builds #26624

asabil opened this issue Feb 11, 2014 · 5 comments
Assignees
@adamv

Comments

@asabil
Copy link
Contributor

asabil commented Feb 11, 2014

For some unknown reason, the wxmac formula defaults to building a monolithic library which is not the default upstream behaviour.

This results in linkage failures with erlang wx integration (#26427, #18291) as well as wxHaskell (#22653). I am personally not a wx expert and didn't manage to get wx erlang to link against the monolithic version.
@adamv
Copy link
Contributor

adamv commented Feb 11, 2014

I don't know why we have this option; would support default to how upstream builds and removing the monolith switch.

@mistydemeo
Copy link
Contributor

Looks like it was added in this commit: 225d53f

@adamv
Copy link
Contributor

adamv commented Feb 11, 2014

We should default to upstream behavior and made saga-opt-in to weird behavior...though of course that means if you install saga and something else that need different options everyone loses.

@MikeMcQuaid
Copy link
Member

@adamv Agreed. Saga can always vendor wxmac with a resource.

@adamv
Copy link
Contributor

adamv commented Feb 25, 2014

I'm making this build --disable-monolithic by default, with no option.

Since I don't know how to tell for instance erlang to do depends_on ... => '--?'.

@adamv adamv self-assigned this Feb 27, 2014
@adamv adamv closed this as completed in 72bbddf Mar 1, 2014
spkane pushed a commit to spkane/homebrew that referenced this issue Mar 3, 2014
@adamv
wxmac: disable monolithic build
9f7ca16 
More software requires non-monolithic builds than the
other way around

Closes Homebrew#26624.
ehershey pushed a commit to ehershey/homebrew that referenced this issue Apr 4, 2014
@adamv @ehershey
wxmac: disable monolithic build
b767433 
More software requires non-monolithic builds than the
other way around

Closes Homebrew#26624.
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamv adamv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adamv @MikeMcQuaid @asabil @mistydemeo