This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Update CLT pkg id for 10.10 and last two for 10.9 #30296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +147,8 @@ module CLT | |||
| STANDALONE_PKG_ID = "com.apple.pkg.DeveloperToolsCLILeo" | |||
| FROM_XCODE_PKG_ID = "com.apple.pkg.DeveloperToolsCLI" | |||
| MAVERICKS_PKG_ID = "com.apple.pkg.CLTools_Executables" | |||
| # also com.apple.pkg.CLTools_Base for >= mavericks_june_2014 | |||
| YOSEMITE_PKG_ID = "com.apple.pkg.CLTools_Base" | |||
There was a problem hiding this comment.
I wonder if we just change the names for both of these PKG_IDs above if they don't just apply to e.g. Mavericks. Will have a look/think. Great find here though, thanks!
|
Pulled a slightly different version, thanks! |
|
Reopening because I screwed up my version. 😢 |
|
@MikeMcQuaid Thanks! Just found out it had been affecting some formulae in my tap as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the CLT pkg id for 10.10, and also for 10.9's mavericks_june_2014 (released June 2nd) and later.
This fixes issues where
MacOS::CLT.installed?was failing to find that the CLT were installed. This would be where users had uninstalled a previous CLT and updated to latest (what I did), or where the CLT were a first-time install.Appears to fix #29954 and #22816. I ran into the
pythonformulahashlibissue usingsuperenv, but it worked withstdenv, which led me to realize thatMacOS::CLT.installed?was not resolving for latest CLT package installs on 10.9. Not sure what other current issues it may fix.