Upgrade Node.js to v4.0.0

[joshmanders]

Today the Node.js team has released v4.0.0 so this formula takes from the io.js formula since v4.0.0 is coming from the io.js codebase.

https://nodejs.org/en/blog/release/v4.0.0/

[mmwtsn]

🎉

This fixes #43713

[DomT4]

This should be applied to the iojs formula in the mean time, yes. The Node formula is remaining on the LTS 0.x.x releases until what was iojs no longer requires a patched npm to run. Likewise, because it requires a patched npm still it is unlikely we'll be adding npm support to formerly known as iojs at this point in time.

Added comment: #43716 (comment)

[joshmanders]

Copying @DomT4's comment from #43716 (comment)

It is likely that the Node formula is going away, or rather being moved to homebrew/versions, and iojs will be renamed nodejs or similar - Once we have an npm that we can just fetch as a tarball and use the same stable mechanism we've been using in node for a long period now. This is not set in stone yet, by any means.

npm cannot live inside the Cellar path. We tried that before and the end result was incredibly troublesome. Unless that has changed and npm can now live in one place whilst installed modules live and persist somewhere else globally that won't be removed across updates/reinstalls/etc the position on that can't change.

Essentially, no npm that we cannot control the build location of can be used. On top of that if people install a different node version from versions the installation of the npm shipped with that formula should not break the main node-esque formula in the core. If people update or downgrade their npm version locally it should not break the node-esque formula.

Package managing another package manager (npm) is difficult and delicate, and we appreciate this is frustrating. We absolutely will move forwards as quickly as we can continue to provide stability to end users, and appreciate patience in that process.

[joshmanders]

I never thought about that stuff, good thinking. I have this formula installing Node.js v4.0.0 right now and don't seem to see any real issues yet. I had stuff already installed globally from when I was using v0.12.7 and all those still seem to work.

[DomT4]

Please don't add thumbs to this conversation; It doesn't speed the process up & it ends up making tracking the various discussions less fun. It'll be merged when all parties involved are happy. Some extra discussion quoted by @killswitch is in #43716 and I'll reply to the latest point there at some point in the next few hours probably.

[mourner]

Great points! Were they brought up to NPM maintainers in some public ticket? The team there is pretty nice and responsive. I'd love to see what they have to say on the issue.

[DomT4]

Left a comment in the other thread very early this morning along the lines of the blockers on this at the moment: #43716 (comment)

Were they brought up to NPM maintainers in some public ticket?

It was discussed heavily in various Homebrew tickets, including #3762, #22408, #27479, #28075 & #36369. Isaacs & Othiym23 have both had a lot of immensely valuable input that has been really useful to us in resolving various sticky points over the long-term.

We try to loop the npm team in on various discussions as obviously Homebrew has been a driver of issues to them in the past and an open relationship between the two teams helps reduce both our maintenance burdens.

[MikeMcQuaid]

Leave the bottle-block as-is, it'll be updated when we pull.

[MikeMcQuaid]

As a general comment: please don't move stuff around or change stuff in version bumps like this unless they are necessary for it to build (and in those cases: please let us know in the PR description). Otherwise there will be more back-and-forth and it'll take longer to get merged. Thanks!

[joshmanders]

@MikeMcQuaid understood. This is the first I've done with any formulas, I just wanted node v4 asap, so I copied the iojs formula and used it for node since node is now using iojs' codebase.

This works fine for me currently, but I have no issues in someone else taking this over who understands the underlining stuff better as @DomT4 pointed out.

[ninjasort]

Looking forward to this merge. Would love to get Node v4

[MikeMcQuaid]

Just to let people know: we won't be merging this until we have a stable, unpatched npm release that supports NodeJS 4.0.0

[iffyuva]

this is sad. is there any discussion thread about new unpatched npm release which we can follow?

[francip]

@MikeMcQuaid seems npm v2.14.3 will be able to support node v4 unpatched. The current npm in node v4 is v2.14.2, which still includes a single patch to make the node tests go green

[chrmoritz]

@francip The patches you are looking for are nodejs/node@b8341e8 and nodejs/node@22097a2 which are bumping node-gyp to 3.0.0 and 3.0.1.

npm 2.14.4 (unstable until next week) was release today which officially bundles node-gyp 3.0.1. So we only have to wait one more week for a stable npm which is fully compatible with all possible Node.js release lines without a patch.

[joshmanders]

Closing as a much better PR exists at #43973

[bcomnes]

In the meantime, we have a working node4 formula in this tap: https://github.com/aredridel/homebrew-iojs

[DomT4]

Thanks for the patience & understanding in this PR @killswitch; appreciate the willingness to work with us constructively.

[joshmanders]

@DomT4 No problem. Thanks for the great work on homebrew. I'd go crazy without it.

[jeromedecoster]

@MikeMcQuaid node 4.1.0 is out today, including updated npm

[bcomnes]

@jeromedecoster we are waiting on npm@2.14.4 in #43973