Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Update fltk.rb to support HEAD for OS X El Capitan #44806

Closed
wants to merge 3 commits into from

Conversation

jmtatsch
Copy link
Contributor

Added HEAD option for building from svn in order to build with OS X El Capitan

Added HEAD option for building from svn in order to build with OS X El Capitan
@@ -11,27 +9,42 @@ class Fltk < Formula

option :universal

stable do
# Fltk 1.3.4 include support for El Capitan. Remove on update.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines (The comment and the depends_on) should be one empty line beneath the :DATA patch line.

@DomT4
Copy link
Member

DomT4 commented Oct 10, 2015

fltk:
 * 4: Trailing whitespace was found
 * 17: Trailing whitespace was found

only head depends on cmake build, removed unneeded comments, cleaned trailing whitespaces
@DomT4
Copy link
Member

DomT4 commented Oct 11, 2015

Still some whitespacing issues here:

        Error: 3 problems in 1 formula
fltk:
 * 4: Trailing whitespace was found
 * 15: Trailing whitespace was found
 * 19: Trailing whitespace was found

hopefully no more trailing whitespace
@DomT4
Copy link
Member

DomT4 commented Oct 11, 2015

I can't seem to clone it non-interactively locally:

==> Cloning http://seriss.com/public/fltk/fltk/branches/branch-1.3/
svn checkout http://seriss.com/public/fltk/fltk/branches/branch-1.3/ /usr/local/var/homebrew/cache/fltk--svn-HEAD
Authentication realm: <http://seriss.com:80> Subversion repository
Password for '':

Authentication realm: <http://seriss.com:80> Subversion repository
Username:
Password for '':

😢. We don't do interactivity as it's bad UX and means automated scripts/builds/etc fall over.

@jmtatsch
Copy link
Contributor Author

That is weird, I don't need to use interactive mode. For me it works just fine and i don't have any creds for their svn server. I can't browse their svn via http though.
Can brew checkout from svn "natively" or is an svn installation necessary as requirement? Can the builedbot check it out?

brew install fltk --HEAD
==> Cloning http://seriss.com/public/fltk/fltk/branches/branch-1.3/
Updating /Library/Caches/Homebrew/fltk--svn-HEAD
==> cmake . -DCMAKE_C_FLAGS_RELEASE= -DCMAKE_CXX_FLAGS_RELEASE= -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/fltk/HEAD -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERB
==> make install
🍺  /usr/local/Cellar/fltk/HEAD: 175 files, 4,5M, built in 84 seconds

@dpo
Copy link
Contributor

dpo commented Oct 12, 2015

Just put this together to build the devel snapshot: https://gist.github.com/5b906b02e585d6f43eec
They advertise that it builds on 10.11. I don't have that system to try.

@jmtatsch
Copy link
Contributor Author

Just checked out the formula @dpo provided. It builds fine on El Cap, doesn't suffer from that strange svn credential problem, but does configure threads and shared properly. Yay!

@dpo
Copy link
Contributor

dpo commented Oct 13, 2015

Note that there seems to be a mirror of the source on Github (https://github.com/Homebrew/homebrew-science/issues/2871#issuecomment-147500027) but I'm not sure how "official" it is.

@DomT4
Copy link
Member

DomT4 commented Oct 13, 2015

Just put this together to build the devel snapshot: https://gist.github.com/5b906b02e585d6f43eec
They advertise that it builds on 10.11. I don't have that system to try.

Would be happy to take a devel build like this, but the upstream website gives the impression it would need daily updating for the URL to keep working. If that's not the case, happy to take it.

@dpo
Copy link
Contributor

dpo commented Oct 13, 2015

I just tried downloading a few past "devel" releases, and it seems like they stick around, at least for a while. I'll prepare a PR.

@dpo dpo mentioned this pull request Oct 13, 2015
dpo added a commit to dpo/homebrew that referenced this pull request Oct 13, 2015
dpo added a commit to dpo/homebrew that referenced this pull request Oct 13, 2015
dpo added a commit to dpo/homebrew that referenced this pull request Oct 13, 2015
dpo added a commit to dpo/homebrew that referenced this pull request Oct 13, 2015
dpo added a commit to dpo/homebrew that referenced this pull request Oct 14, 2015
@DomT4 DomT4 closed this in 004f134 Oct 17, 2015
@jmtatsch jmtatsch deleted the patch-1 branch October 17, 2015 04:18
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants