teensy_loader_cli: add HEAD patch to avoid libusb access error on Mac OS #45558
Conversation
| @@ -1,9 +1,10 @@ | |||
| class TeensyLoaderCli < Formula | |||
| desc "Command-line integration for Teensy USB development boards" | |||
| homepage "https://www.pjrc.com/teensy/loader_cli.html" | |||
| depends_on "libusb-compat" | |||
There was a problem hiding this comment.
This should be down below the head block.
There was a problem hiding this comment.
but to compile 2.1 with OS=LINUX also require libusb
There was a problem hiding this comment.
Oh, not in the head block, just below it and above the install block. Otherwise brew audit --strict teensy_loader_cli will complain.
| @@ -12,9 +12,18 @@ class TeensyLoaderCli < Formula | |||
| sha256 "dcd10140babb4d2937ce376c89e9c24a2e8046d2cabdad2cfdbc2542afa14471" => :mavericks | |||
| end | |||
|
|
|||
| head do | |||
| url "https://github.com/PaulStoffregen/teensy_loader_cli.git" | |||
| patch do | |||
There was a problem hiding this comment.
Please submit this patch upstream (or at least a bug report) and use that link. We don't particularly want to use a commit from an unofficial repo.
|
Ping? |
|
@bfontaine Let's wait for response from upstream. PaulStoffregen/teensy_loader_cli#19 |
|
As responded from the upstream. The patch is just a quick and dirty workaround for the new Mac OS X version, and is using the Linux build codes. Merging the patch to the upstream will break the Linux code. Thus I suggest merge this patch in Homebrew and wait for any solid progress from the upstream to fix the native Mac OS X build. |
Even in that case: I'd rather we didn't add new features that rely on patches ( |
|
Fixed in #48252. |
According to PaulStoffregen/teensy_loader_cli#11
it's suggested to compile with
OS=LINUXand include libusb, and due to an issue described inhttps://github.com/PaulStoffregen/teensy_loader_cli/blob/master/teensy_loader_cli.c#L246-L248
libusb behave differently on Mac OS. Thus the patch comments out the lines as described to fix the problem.