-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
I updated node to 0.6.3. from 0.6.2
Not sure it's as simple this time. NPM is now also installed on "make install" and I remember a bit of a debate whether NPM (already a package manager) should be available within homebrew at all. |
So between 0.6.2 and 0.6.3, NPM was added to node-core? |
Apparently so: nodejs/node-v0.x-archive@b159c6d#ChangeLog |
Hmmm.... Is there a |
http://groups.google.com/group/nodejs/browse_thread/thread/d592e5f194588aa7 Sounds like there might be a 0.6.4 soon anyway, and there have been a few grumblings about the "forced install" of npm. Hopefully they will add a way to disable, or optionally install. Sorry for the trouble, but at least we have this issue to document the problem. |
What do you recommend here? Last time we installed NPM via Homebrew it resulted in a lot of bug reports for you. |
Based on the latest comments to the Google Groups thread above it sounds like a 'no npm' install option will be added in the next release. You may either close this pull request or leave it open (for higher visibility until the fix is available) at your discretion. |
Will there be an option to install node including npm via homebrew? I'd rather install node via homebrew than via Also, I'm curious, what's the reason for not installing npm by default? |
In the Google groups thread there is a reply from someone saying that MacPorts has a patch that disables the NPM install. If someone wants to rebase this to use their patch, we could pull it. |
It's just the removal of this one line: https://trac.macports.org/browser/trunk/dports/devel/nodejs/files/patch-wscript-npm.diff |
What about doing this: def install
inreplace 'wscript' do |s|
...
# v0.6.3 installs npm; disable that line
s.sub! 'install_npm(bld)', 'print("Homebrew is skipping npm install")'
end
...
end We could also add another caveat as the print doesn't get piped to console during brew install. |
Why is having npm bundled and installed along with node a bad thing? |
We used to have a NPM formula, but it caused a lot of problems for Homebrew and NPM---primarily because NPM takes responsibility for its own upgrades. This means that Homebrew and NPM spend too much time fighting each other to be worth the trouble caused to both projects and their users. After much discussion with Isaac Schlueter, the NPM project lead, we decided to pull NPM from Homebrew. Since NPM is still self-upgrading, having it come back piggybacked on a Node install would just bring old skeletons out of the closet. See issue #3762 for full details. |
Just wondering, do we have the same problem with ruby (which installs gem)? |
As far as I remember, Gem doesn't assert responsibility for its self to the same degree that NPM does. For example, NPM handles its own uninstallation and Isaac was getting a lot of bug reports concerning In the end, Isaac made the call to pull NPM from Homebrew in #4223 and we will respect his wishes until he advises otherwise. We could keep busy with "what about gem/pip/cpan/cabal/..." discussions all week, but the deciding factor in this discussion is that the maintainer of NPM doesn't think NPM belongs in Homebrew and we agree with him. |
Note that Ruby (for gems) and Python (for pip) formulae go through some hoops to set paths correctly. At least on the Python side the set up is kind of touchy. |
Actually, I made that call at the beginning. It was @mxcl who made the call in the end to remove it; I just agreed with him :) There are two things that are important to consider here. I think we don't have to do anything particularly crazy or drastic with the node recipe to make everyone happy. We can probably even let it install npm, and perhaps allow it to self-update. Maybe an npm recipe could be revisited, even.
This way, npm could install stuff into The big blocker last time was that npm was so young, and updating quickly. However, things are getting more and more stable as we move forward. I suspect that some time this year, npm will be more or less finished. The big hurdle was getting onto a javascript tar implementation, and that's coming along nicely. Since I'm going to end up seeing bug reports for npm regardless of how it's installed, I'd greatly appreciate the ability to review any npm recipe to make sure it doesn't revive any skeletons ;) |
Related: nodejs/node-v0.x-archive@3ca0517 There is now a --without-npm configure option. I do think it would probably be best to explore an npm recipe some time soon, but as a separate thing. |
0.6.4 has landed. I've created a new pull request. |
I updated node to 0.6.3. from 0.6.2