Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honahx test cache manifest pr #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Honahx test cache manifest pr #4

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e00b0b
cache manifests
chinmay-bhat May 27, 2024
da2a295
update API
chinmay-bhat Jun 4, 2024
81a85ab
small fix
chinmay-bhat Jun 4, 2024
5d943a2
update
HonahX Jun 12, 2024
237ad2b
update
HonahX Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pyiceberg/table/snapshots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import time
from collections import defaultdict
from enum import Enum
from functools import lru_cache
from typing import TYPE_CHECKING, Any, DefaultDict, Dict, Iterable, List, Mapping, Optional

from pydantic import Field, PrivateAttr, model_serializer
Expand Down Expand Up @@ -228,6 +229,15 @@ def __eq__(self, other: Any) -> bool:
)


@lru_cache
def _manifests(io: FileIO, manifest_list: Optional[str]) -> List[ManifestFile]:
"""Return the manifests for the given snapshot."""
if manifest_list not in (None, ""):
file = io.new_input(manifest_list) # type: ignore
return list(read_manifest_list(file))
return []


class Snapshot(IcebergBaseModel):
snapshot_id: int = Field(alias="snapshot-id")
parent_snapshot_id: Optional[int] = Field(alias="parent-snapshot-id", default=None)
Expand All @@ -248,10 +258,8 @@ def __str__(self) -> str:
return result_str

def manifests(self, io: FileIO) -> List[ManifestFile]:
if self.manifest_list is not None:
file = io.new_input(self.manifest_list)
return list(read_manifest_list(file))
return []
"""Return the manifests for the given snapshot."""
return _manifests(io, self.manifest_list)


class MetadataLogEntry(IcebergBaseModel):
Expand Down
Loading