Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated lazy option from datadog adapter #41

Closed

Conversation

sobstel
Copy link

@sobstel sobstel commented Feb 24, 2024

Removed lazy option for datadog adapter as it is now deprecated in datadog (DataDog/dd-trace-rb#2931) and what's worse it makes httpx to throw warnings for each usage (5 warning together).

WARN -- ddtrace: [ddtrace] Defining an option as lazy is deprecated for removal. Options now always behave as lazy. Please remove all references to the lazy setting.
+# Non-lazy options that were previously stored as blocks are no longer supported. If you used this feature, please let us know by opening an issue on: https://github.com/datadog/dd-trace-rb/issues/new so we can better understand and support your use case. This will be enforced in the next major release.

@HoneyryderChuck
Copy link
Owner

Hi, thx for the patch.

Which version(s) of ddtrace are affected by this? AFAIK this does not affect "latest"

@sobstel
Copy link
Author

sobstel commented Feb 26, 2024

Which version(s) of ddtrace are affected by this? AFAIK this does not affect "latest"

I've noticed it after upgrading to 1.20.0

It is on master branch: https://github.com/DataDog/dd-trace-rb/blob/81e6060550e4c860ae6ac8b26d0be3dea0e375d0/lib/datadog/core/configuration/option_definition.rb#L98C1-L106C14

and lazy doesn't work and throws warnings since 1.13.0 (https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md#added-7)

@HoneyryderChuck
Copy link
Owner

created this MR to address this. Your PR was removing .lazy calls in blocks for versions older than 1.13, as well as unversioned code blocks.

Closing the MR, but feel free to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants