Added highlevel ability to provide lineCap style #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2020 10:22
…rectangle, square, ellipse, circle, svgpath
….draw functions: line, square, rectangle, circle, ellipse
added 4 commits
June 24, 2020 18:30
# Conflicts: # apps/deno/tests/test12.ts # apps/node/tests/test1.ts # apps/node/tests/test12.ts # apps/rn/src/tests/test1.js # apps/rn/src/tests/test12.js # apps/web/test12.html # src/api/PDFPage.ts # src/api/PDFPageOptions.ts # src/api/operations.ts
|
@Hopding All done, let me know if it needs anything else! :) |
|
@soadzoor Could you please merge |
# Conflicts: # apps/deno/tests/test1.ts # apps/deno/tests/test12.ts # apps/node/tests/test1.ts # apps/node/tests/test12.ts # apps/rn/src/tests/test1.js # apps/rn/src/tests/test12.js # apps/web/test1.html # apps/web/test12.html # src/api/PDFPage.ts # src/api/PDFPageOptions.ts # src/api/operations.ts
|
@Hopding sure, done! |
Hopding
approved these changes
Jun 26, 2020
Hopding
pushed a commit
that referenced
this pull request
Aug 30, 2021
* Added highlevel ability to provide dashArray, and dashPhase for page.drawLine * Added dashArray and dashPhase for the rest of the drawing functions: rectangle, square, ellipse, circle, svgpath * Updated tests to reflect dashpattern changes * Added highlevel ability to provide lineCapStyle to the following page.draw functions: line, square, rectangle, circle, ellipse * Applying requested changes * Updated tests to reflect changes * Applying requested changes: lineCap to borderLineCap Co-authored-by: Peter Varga <peter.varga@xyicon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #498 , but for lineCap.
There was a comment from @Hopding , saying:
// TODO: Should assert
options.lineCaphere, but is a breaking changeI'm not sure why this would be a breaking change, we can just default to
LineCapStyle.Butt, or we can ignore this parameter if it's not provided (like this PR does). Maybe there's more to it than I can see, so let me know! :)