Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib ES2016 #751

Closed
wants to merge 373 commits into from
Closed

lib ES2016 #751

wants to merge 373 commits into from

Conversation

mcshaz
Copy link
Contributor

@mcshaz mcshaz commented Jan 14, 2021

address #747 namely use of the Map object, Array.from and Array.prototype.includes extensively through library

@Hopding
Copy link
Owner

Hopding commented Jan 16, 2021

Related to #745 (comment)

@Hopding
Copy link
Owner

Hopding commented Aug 31, 2021

@mcshaz apologies for my late response. I've been very busy these past few months taking care of some personal stuff and starting my new job at GitHub 🙂

I'm hoping to get around to reviewing this PR in the next few weeks now that I've got some more free time.

Please note that you'll need to either update this PR (via a force push) or open a new PR with your changes. The tl;dr is that I recently had to do a fairly extensive git history rewrite that caused a bunch of conflicts. Please read https://github.com/Hopding/pdf-lib#git-history-rewrite for details. Apologies for the hassle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.