refactor!: migrate from thiserror
to snafu
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See spaceandtimelabs#174 for rationale
What changes are included in this PR?
NOTE: the individual commits may be good to review individually.
snafu
does not support tuple structs.#[derive(Error)]
is substituted with the analogous#[derive(Snafu)]
. In particular:#[error(...)]
attributes are substituted with equivalent#[snafu(display(...))]
attributes#[error(transparent)]
attributes are substituted with equivalent#[snafu(transparent)]
attributes (which also derive the correspondingFrom
implementation)ConversionError::TimestampConversionError
, the#[snafu(context(false), display(...))]
attribute is used for deriving aFrom
implementation, and at the same time maintain the custom error messagestd
feature is introduced for theproof-of-sql
crate, which in turns activates thesnafu/std
feature. Thestd
feature is required for theposql_db
example, becauseClap
relies on thestd::error::Error
trait.thiserror
still appears in the dependency tree (cargo tree -i thiserror
), but only as a transitive dependency (viablitzar
, and dev-dependencies)Are these changes tested?
Yes. This PR is a refactoring, and all existing tests pass.