Python tests fixes #544
Merged
Python tests fixes #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shieldedpooldeprecation_rpc.py: due to tx-hash-based selection of utxos/notes, z_mergetoaddress output can change from run to run, eventually incurring in insufficiently mature funds; this has been fixed by making funds mature earlier (no performance impact) wallet_mergetoaddress_2.py: after updating the chain setup archive, an assertion with previously ad hoc defined value was failing; this has been fixed updating that value
drgora
approved these changes
May 8, 2023
ptagl
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two Python tests:
shieldedpooldeprecation_rpc.py: due to tx-hash-based selection of utxos/notes, z_mergetoaddress output can change from run to run, eventually incurring in insufficiently mature funds; this has been fixed by making funds mature earlier (no performance impact),
wallet_mergetoaddress_2.py: after updating the chain setup archive, an assertion with previously ad hoc defined value was failing; this has been fixed updating that value.