Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gp/general refactoring #564

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Gp/general refactoring #564

merged 1 commit into from
Jun 22, 2023

Conversation

JackPiri
Copy link
Contributor

@JackPiri JackPiri commented Jun 8, 2023

Very general refactoring.

@JackPiri JackPiri force-pushed the gp/general_refactoring branch 6 times, most recently from 679418c to 49de7dd Compare June 13, 2023 13:07
Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR, thanks! Left a minor non-blocking comment, feel free to ignore!

src/test/util_tests.cpp Outdated Show resolved Hide resolved
@JackPiri JackPiri force-pushed the gp/general_refactoring branch 2 times, most recently from 9bf1a7e to 83b935e Compare June 21, 2023 14:08
@JackPiri JackPiri force-pushed the gp/general_refactoring branch 3 times, most recently from bb9b3ab to c36d4ed Compare June 22, 2023 10:16
syntax and style cleanup
mapArgs usage
client versioning alignment
fixed misplaced semicolons in python tests
python tests cleaning
@JackPiri JackPiri force-pushed the gp/general_refactoring branch from c36d4ed to 884a5df Compare June 22, 2023 10:26
@ptagl ptagl merged commit 90503e9 into main Jun 22, 2023
@ptagl ptagl deleted the gp/general_refactoring branch June 22, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants