Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GUI when reindexing procedure is interrupted #597

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix for GUI when reindexing procedure is interrupted #597

merged 1 commit into from
Aug 30, 2023

Conversation

JackPiri
Copy link
Contributor

@JackPiri JackPiri commented Aug 29, 2023 •
edited
Loading

This PR produces better GUI behavior in case of interrupted reindex/reindexfast procedure.

To reproduce:

  1. make sure to have significant high blockchain (100+ blockXXX.dat files)
  2. start zend with reindexfast parameter
  3. interrupt reindexfast after blocks headers import, during raw blocks import (for example blk001.dat)
  4. start zend without reindexfast parameter
  5. reindexfast procedure resumes but without showing properly progress information (seems to be stucked at "Init message (node already loaded):")

Before fix (at step 4 above):
before.webm

After fix (at step 4 above):
after.webm

@JackPiri JackPiri force-pushed the gp/reindexing_GUI_fix branch from ba542b9 to 97e17fa Compare August 29, 2023 15:49
a-petrini
a-petrini approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

titusen
titusen approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@titusen titusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ptagl ptagl merged commit d24684b into main Aug 30, 2023
@ptagl ptagl deleted the gp/reindexing_GUI_fix branch August 30, 2023 07:11
a-petrini pushed a commit that referenced this pull request Aug 30, 2023
@JackPiri @a-petrini
Cherry-picking PR #597 gp/reindexing_GUI_fix
f30ca39
a-petrini pushed a commit that referenced this pull request Aug 30, 2023
@JackPiri @a-petrini
Cherry-picking PR #597 gp/reindexing_GUI_fix
60b502f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-petrini a-petrini a-petrini approved these changes

@titusen titusen titusen approved these changes

@ptagl ptagl ptagl approved these changes

@drgora drgora Awaiting requested review from drgora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackPiri @ptagl @titusen @a-petrini