Update mempool size limit code and test #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPiri
reviewed
Sep 28, 2023
JackPiri
reviewed
Sep 28, 2023
JackPiri
reviewed
Sep 28, 2023
JackPiri
reviewed
Sep 28, 2023
JackPiri
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
The PR is fine to me, please just address comment https://github.com/HorizenOfficial/zen/pull/611/files#r1340382257, the others can be ignored if you prefer.
Thanks
a-petrini
approved these changes
Sep 29, 2023
drgora
force-pushed
the
dr/mempool_size_limit_fixup
branch
2 times, most recently
from
d38a075 to
93b95cd
Compare
This commit fixes minor issues which caused the size limit to be exceeded temporarily under specific circumstances. Also mempool_size_limit.py is updated to cover such case.
ptagl
force-pushed
the
dr/mempool_size_limit_fixup
branch
from
93b95cd to
d72e1df
Compare
ptagl
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes minor issues which caused the size limit to be exceeded temporarily under specific circumstances.
In addition, the blockchain snapshot used for tests
mempool_size_limit.pyandmempool_size_limit_more.pyhas been moved to backblaze and removed from this repository.