Shielded pool removal #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPiri
reviewed
Jan 9, 2024
JackPiri
reviewed
Jan 9, 2024
JackPiri
reviewed
Jan 9, 2024
JackPiri
approved these changes
Jan 9, 2024
ptagl
reviewed
Jan 10, 2024
JackPiri
force-pushed
the
gp/shielded_pool_removal
branch
from
8bc0e13 to
a6c9774
Compare
a-petrini
force-pushed
the
gp/shielded_pool_removal
branch
from
94db13d to
79631cb
Compare
Core logic for hardfork
Now shieldedpooldeprecation.py tests for RPC error and consensus errors zcjoinsplit.py has been reverted to its previous scope (basic raw joinsplit test)
JackPiri
force-pushed
the
gp/shielded_pool_removal
branch
from
79631cb to
89dd546
Compare
JackPiri
force-pushed
the
gp/shielded_pool_removal
branch
from
89dd546 to
9d68234
Compare
ptagl
force-pushed
the
gp/shielded_pool_removal
branch
from
9d68234 to
cabcaf5
Compare
ptagl
pushed a commit
that referenced
this pull request
Jan 29, 2024
…elded_removal After the development of the removal of shielded transactions #628, docs on the repository have been updated to reflect the current status of Zend and remove references to any feature that is not available anymore. Some sections have been kept and marked as "deprecated" since they may still be useful somehow after the hard fork activation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the shielded pool from zend.
In particular, removes the possibility of submitting transactions involving shielded notes, hence t->z, z->z and z->t transactions will no longer be accepted and processed.
This PR also modifies all the RPC commands directly related to these transactions -
z_sendmanyandz_mergetoaddress- and adds deprecation warnings to all the remainingz_commands.