Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test reproducing mempool conflicts #640

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

a-petrini
Copy link
Contributor

This PR introduces a Python test reproducing a scenario where conflicting certificates and transactions should be correctly evicted from the mempool.

Copy link
Contributor

@drgora drgora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few minor comments, but this definitely looks good to me, thanks!

qa/rpc-tests/sc_mempool_conflict.py Outdated Show resolved Hide resolved
qa/rpc-tests/sc_mempool_conflict.py Show resolved Hide resolved
qa/rpc-tests/sc_mempool_conflict.py Outdated Show resolved Hide resolved
@ptagl ptagl merged commit 9f1f1f0 into main Mar 29, 2024
1 check passed
@ptagl ptagl deleted the ap/sc_mempool_conflict_test branch March 29, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants