-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Create new number component #116
Comments
@zinyando is looking into this one. |
@tangollama I got a little busy but I will take another stab at it tomorrow. Will post the link to the PR when its ready in a day or 2 cc @jkleinsc |
Great. Thank you. Typed or dictated imperfectly on my iPhone (717.385.9970)
|
@jkleinsc is this issue still valid? Validation seems to not accept commas in numbers anymore. |
@zinyando you are correct in that validation doesn't allow commas. For usability purpose, I still think we should create a component that will let people enter a number with commas but will save the value without commas. |
Note that depending on the localization a comma can be considered a decimal point. |
@zinyando are you thinking about working this? |
Convert ViewMedications.test.tsx to RTL
Right now our number validation allows for numbering like 123,456 but codewise we are expecting numbers without commas. We should create a component that will let people enter a number with commas but will save the value without commas.
Either that or we need to change how validation works to eliminate commas but that is not as friendly
TODO
The text was updated successfully, but these errors were encountered: