Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Payment profiles should support specifying a set fee #35

Closed
jkleinsc opened this issue Apr 2, 2015 · 17 comments
Closed

Payment profiles should support specifying a set fee #35

jkleinsc opened this issue Apr 2, 2015 · 17 comments
Assignees
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions

Comments

@jkleinsc
Copy link
Member

jkleinsc commented Apr 2, 2015

Patient pays set fee of 1000/2000/3000, etc

@jkleinsc jkleinsc added 🚀enhancement an issue/pull request that adds a feature to the application philippines labels Apr 2, 2015
@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Sep 25, 2015
@tangollama tangollama modified the milestone: HospitalRun 1.0 Oct 14, 2015
@LennonR
Copy link

LennonR commented Dec 6, 2015

@tangollama I'll give this a go. Are there any additional requirements besides adding "set fee" to the Pricing Profile forms and display pages in the Billing/Price Profiles section?

@LennonR
Copy link

LennonR commented Dec 6, 2015

@tangollama Also, when I run the tests on a newly cloned project, I get 60 test fails out of 684. Is that expected or is something wrong with my local build?

@jkleinsc
Copy link
Member Author

jkleinsc commented Dec 6, 2015

@LennonR when did you fork? Yesterday I committed a fix for tests that were failing but they should be all passing now. Maybe try to rebase?

@LennonR
Copy link

LennonR commented Dec 6, 2015

@jkleinsc I forked today a few hours ago

@jkleinsc
Copy link
Member Author

jkleinsc commented Dec 6, 2015

@LennonR what tests are failing?

@LennonR
Copy link

LennonR commented Dec 6, 2015

@jkleinsc 1, 4-7, 10-13, 16-33, 36-40, 43-45, 48, 51-54, 57-65, 68-76, 79, 622

@jkleinsc
Copy link
Member Author

jkleinsc commented Dec 6, 2015

Is that happening running npm test/ember test ? Do you have phantomjs installed and if so what version? The command line tests rely on phantomjs v2. You can also run the tests in the browser by running ember serve and then going to localhost:4200/tests

@LennonR
Copy link

LennonR commented Dec 6, 2015

I had phantomjs < version 2 so that was probably the problem. I ran them in the browser and they all passed. Thanks for the help.

OK, so back to my original question:

Are there any additional requirements besides adding "set fee" to the Pricing Profile forms and display index page in the Price Profiles section?

@jkleinsc
Copy link
Member Author

jkleinsc commented Dec 6, 2015

The intention for this feature is that a patient would only pay a set fee regardless of how much they were charged on an invoice. So the two places this needs to be addressed in are the crud for pricing profiles and then in the invoice section, when a patient with a pricing profile of this type is selected for an invoice, the total that the patient owes is pulled from the profile and the invoice reflects the amount as what the patient owes by applying a hospital discount for the difference. Does that make sense?

@LennonR
Copy link

LennonR commented Dec 6, 2015

I think so. Let me try an example.

We have an invoice for $2000. The pricing profile is chosen that has a set fee of $500. The invoice then needs to have a hospital discount of $1500 applied so that the final total is $500.

Is that correct?

@tangollama
Copy link
Member

Correct.

@tangollama
Copy link
Member

@LennonR, if you're going to work on this, great. If so, I'll change the status from Help Wanted to In Progress.

@LennonR
Copy link

LennonR commented Mar 15, 2016

@tangollama Sorry about this. You can change the status to help wanted.

@tangollama
Copy link
Member

no worries @LennonR. Thanks for replying back to confirm.

@tangollama
Copy link
Member

Discussing this with @worrlo and therefore updating the requirements. Ideally the edit interface would now include an option to describe what kind of payment profile this is: a discount or a capped amount. I'm guessing this involves two new attributes on a payment profile:

  1. a payment profile type
  2. a capped amount (this would be only be displayed in a scenario where capped amount was selected as the "type")

This information would then be applied when the involve is being built. If capped, do capped logic (i.e. the patient is only responsible up to a certain amount), else do the existing discount logic.

screen shot 2016-05-30 at 3 46 23 pm

@tangollama tangollama self-assigned this Sep 24, 2016
@jglovier jglovier removed the tweet label Sep 24, 2016
@tangollama
Copy link
Member

FYI, I've made some progress on this, but it's not done yet. I'll keep working on it and try to get in in for 1.0.

@tangollama
Copy link
Member

Resolved in master

matteovivona pushed a commit that referenced this issue Jan 15, 2021
Convert scheduling/appointments/edit/EditAppointment.test.tsx to RTL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions
Projects
None yet
Development

No branches or pull requests

4 participants